Issue 2709633009: Always return computed errors, even for not added files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2709633009: Always return computed errors, even for not added files. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Always return computed errors, even for not added files. There is no penalty for computing it, we have already computed, it is just a matter of returning them or not. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f19f6d8ca6914bb0f24f441e4886ae31a043822f

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		2 chunks	+2 lines, -5 lines	0 comments	Download
	M	pkg/analyzer/test/src/dart/analysis/driver_test.dart	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 10 months ago (2017-02-23 21:55:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f19f6d8ca6914bb0f24f441e4886ae31a043822f (presubmit successful).