Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/clang/scripts/update.py

Issue 2709613004: upload clang pdbs to chrome's symbol server (Closed)
Patch Set: package Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/clang/scripts/package.py ('K') | « tools/clang/scripts/package.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index dc7a439b2980359e2a8f26a5d65dd5b5448b0f8a..b96f02d3bb8889f862782abc13ab9d7c5dafc0c4 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -619,6 +619,13 @@ def UpdateClang(args):
cflags += ['-DLLVM_FORCE_HEAD_REVISION']
cxxflags += ['-DLLVM_FORCE_HEAD_REVISION']
+ # Build PDBs for archieval on Windows. Don't use RelWithDebInfo since it
scottmg 2017/02/21 23:38:49 No 'e' in archival.
+ # has different optimization defaults than Release.
+ if sys.platform == 'win32' and args.bootstrap:
+ cflags += ['/Zi']
+ cxxflags += ['/Zi']
+ ldflags += ['/DEBUG', '/OPT:REF', '/OPT:ICF']
+
CreateChromeToolsShim()
deployment_env = None
« tools/clang/scripts/package.py ('K') | « tools/clang/scripts/package.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698