Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 27096003: Use DEFINE_NODE_TYPE_CASTS instead of using manual toSVGFooElement() (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use DEFINE_NODE_TYPE_CASTS instead of using manual toSVGFooElement() Thanks to introduce DEFINE_NODE_TYPE_CASTS in r159446, we can replace manual toSVGFooElement() with DEFINE_NODE_TYPE_CASTS(). It supports more various helper functions as well as we can use it easily. Thanks to use it, this cl removes unnecessary type casts. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -214 lines) Patch
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -11 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFEFuncAElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFEFuncBElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFEFuncGElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFEFuncRElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFilterElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFontElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFontFaceNameElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGGlyphElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGGlyphRefElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGHKernElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGImageElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGLineElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGMPathElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGMaskElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGMissingGlyphElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGPathElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGPolygonElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGPolylineElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGRectElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGScriptElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGStyleElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGTextElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGVKernElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGViewElement.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-10-12 10:10:21 UTC) #1
tkent
lgtm
7 years, 2 months ago (2013-10-12 12:48:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/27096003/1
7 years, 2 months ago (2013-10-12 12:48:33 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-12 14:16:26 UTC) #4
Message was sent while issue was closed.
Change committed as 159516

Powered by Google App Engine
This is Rietveld 408576698