MD Settings: Internet page cleanup + simple tests

chrome/test/data/webui/settings/fake_networking_private.js

Index: chrome/test/data/webui/settings/fake_networking_private.js
diff --git a/chrome/test/data/webui/settings/fake_networking_private.js b/chrome/test/data/webui/settings/fake_networking_private.js
new file mode 100644
index 0000000000000000000000000000000000000000..32dbe850a722f06b15baa4f84a0289da676e7389
--- /dev/null
+++ b/chrome/test/data/webui/settings/fake_networking_private.js
@@ -0,0 +1,156 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.

[michaelpg, 2017/02/27 01:48:53]

2017

[stevenjb, 2017/02/27 17:38:33]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview Fake implementation of chrome.networkingPrivate for testing.
+ */
+cr.define('settings', function() {
+  /**
+   * @constructor
+   * @implements {NetworkingPrivate}
+   */
+  function FakeNetworkingPrivate() {
+    /** @type {!Object<chrome.networkingPrivate.DeviceStateProperties>} */
+    this.deviceStates_ = {};
+
+    /** @type {!Array<!CrOnc.NetworkStateProperties>} */
+    this.networkStates_ = [];
+
+    /** @type {!{chrome.networkingPrivate.GlobalPolicy}} */
+    this.globalPolicy_ = {};
+
+    this.resetForTest();
+  }
+
+  FakeNetworkingPrivate.prototype = {
+    resetForTest() {
+      this.deviceStates_ = {
+        Ethernet: { Type: 'Ethernet', State: 'Enabled' },

[michaelpg, 2017/02/27 01:48:53]

nit: no space after { or before } is usually what I see

[stevenjb, 2017/02/27 17:38:33]

Done. (Ran clang format)

+        WiFi: { Type: 'WiFi', State: '' },
+        Cellular: { Type: 'Cellular', State: '' },
+        WiMAX: { Type: 'WiMAX', State: '' },
+      };
+
+      this.networkStates_ = [
+        {GUID: 'eth0_guid', Type: 'Ethernet'},
+      ];
+
+      this.globalPolicy_ = {};
+    },
+
+    /** @param {!Array<!CrOnc.NetworkStateProperties>} network */
+    addNetworksForTest: function(networks) {
+      this.networkStates_ = this.networkStates_.concat(networks);
+    },
+
+    /**
+     * @param {string} type
+     * @return {?chrome.networkingPrivate.DeviceStateProperties}
+     */
+    getDeviceStateForTest: function(type) {
+      return this.deviceStates_[type] || null;
+    },
+
+    /** @override */
+    getProperties: assertNotReached,
+
+    /** @override */
+    getManagedProperties: assertNotReached,
+
+    /** @override */
+    getState: assertNotReached,
+
+    /** @override */
+    setProperties: assertNotReached,
+
+    /** @override */
+    createNetwork: assertNotReached,
+
+    /** @override */
+    forgetNetwork: assertNotReached,
+
+    /** @override */
+    getNetworks: function(filter, callback) {
+      callback(this.networkStates_);
+    },
+
+    /** @override */
+    getDeviceStates: function(callback) {
+      var devices = [];
+      Object.keys(this.deviceStates_).forEach(function(type) {
+        var state = this.deviceStates_[type];
+        if (state.State != '')
+          devices.push(state);
+      }.bind(this));
+      callback(devices);
+    },
+
+    /** @override */
+    enableNetworkType: function(type) {
+      this.deviceStates_[type].State = 'Enabled';
+      this.onDeviceStateListChanged.callListeners();
+    },
+
+    /** @override */
+    disableNetworkType: function(type) {
+      this.deviceStates_[type].State = 'Disabled';
+      this.onDeviceStateListChanged.callListeners();
+    },
+
+    /** @override */
+    requestNetworkScan: function() {},
+
+    /** @override */
+    startConnect: assertNotReached,
+
+    /** @override */
+    startDisconnect: assertNotReached,
+
+    /** @override */
+    startActivate: assertNotReached,
+
+    /** @override */
+    verifyDestination: assertNotReached,
+
+    /** @override */
+    verifyAndEncryptCredentials: assertNotReached,
+
+    /** @override */
+    verifyAndEncryptData: assertNotReached,
+
+    /** @override */
+    setWifiTDLSEnabledState: assertNotReached,
+
+    /** @override */
+    getWifiTDLSStatus: assertNotReached,
+
+    /** @override */
+    getCaptivePortalStatus: assertNotReached,
+
+    /** @override */
+    unlockCellularSim: assertNotReached,
+
+    /** @override */
+    setCellularSimState: assertNotReached,
+
+    /** @override */
+    getGlobalPolicy: function(callback) {
+      callback(this.globalPolicy_);
+    },
+
+    /** @type {!FakeChromeEvent} */
+    onNetworksChanged: new FakeChromeEvent(),
+
+    /** @type {!FakeChromeEvent} */
+    onNetworkListChanged: new FakeChromeEvent(),
+
+    /** @type {!FakeChromeEvent} */
+    onDeviceStateListChanged: new FakeChromeEvent(),
+
+    /** @type {!FakeChromeEvent} */
+    onPortalDetectionCompleted: new FakeChromeEvent(),
+  };
+
+  return {FakeNetworkingPrivate: FakeNetworkingPrivate};
+});