MD Settings: Internet page cleanup + simple tests

chrome/browser/resources/settings/internet_page/internet_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-internet-page' is the settings page containing internet
  * settings.
  */
 Polymer({
@@ skipping 11 matching lines @@
       value: chrome.networkingPrivate,
     },
 
     /** Preferences state. */
     prefs: {
       type: Object,
       notify: true,
     },
 
     /**
+     * The device state for each network device type. Set by network-summary.
+     * @type {!Object<chrome.networkingPrivate.DeviceStateProperties>|undefined}
+     * @private
+     */
+    deviceStates: {
+      type: Object,
+      notify: true,
+    },
+
+    /**
+     * Highest priority connected network or null. Set by network-summary.
+     * @type {?CrOnc.NetworkStateProperties|undefined}
+     */
+    defaultNetwork: {
+      type: Object,
+      notify: true,
+    },
+
+    /**
      * The network type for the known networks subpage.
      * @private
      */
     knownNetworksType_: String,
 
     /**
      * Whether the 'Add connection' section is expanded.
      * @private
      */
     addConnectionExpanded_: {
@@ skipping 10 matching lines @@
      * @private
      */
     thirdPartyVpnProviders_: {
       type: Array,
       value: function() {
         return [];
       }
     },
   },
 
+  // Element event listeners
+  listeners: {
+    'device-enabled-toggled': 'onDeviceEnabledToggled_',
+    'show-detail': 'onShowDetail_',
+    'show-known-networks': 'onShowKnownNetworks_',
+  },
+
+  // chrome.networkingPrivate listeners
+  /** @private {Function} */
+  onExtensionAddedListener_: null,
+
+  /** @private {Function} */
+  onExtensionRemovedListener_: null,
+
+  /** @private {Function} */
+  onExtensionDisabledListener_: null,
+
   /** @override */
   attached: function() {
-    this.boundOnExtensionAdded_ = this.boundOnExtensionAdded_ ||
+    this.onExtensionAddedListener_ = this.onExtensionAddedListener_ ||
         this.onExtensionAdded_.bind(this);
-    chrome.management.onInstalled.addListener(this.boundOnExtensionAdded_);
-    chrome.management.onEnabled.addListener(this.boundOnExtensionAdded_);
+    chrome.management.onInstalled.addListener(this.onExtensionAddedListener_);
+    chrome.management.onEnabled.addListener(this.onExtensionAddedListener_);
 
-    this.boundOnExtensionRemoved_ = this.boundOnExtensionRemoved_ ||
+    this.onExtensionRemovedListener_ = this.onExtensionRemovedListener_ ||
         this.onExtensionRemoved_.bind(this);
     chrome.management.onUninstalled.addListener(
-        this.boundOnExtensionRemoved_);
+        this.onExtensionRemovedListener_);
 
-    this.boundOnExtensionDisabled_ = this.boundOnExtensionDisabled_ ||
+    this.onExtensionDisabledListener_ = this.onExtensionDisabledListener_ ||
         this.onExtensionDisabled_.bind(this);
-    chrome.management.onDisabled.addListener(this.boundOnExtensionDisabled_);
+    chrome.management.onDisabled.addListener(this.onExtensionDisabledListener_);
 
     chrome.management.getAll(this.onGetAllExtensions_.bind(this));
 
     this.networkingPrivate.getGlobalPolicy(function(policy) {
       this.globalPolicy_ = policy;
     }.bind(this));
   },
 
   /** @override */
   detached: function() {
     chrome.management.onInstalled.removeListener(
-        assert(this.boundOnExtensionAdded_));
+        assert(this.onExtensionAddedListener_));
     chrome.management.onEnabled.removeListener(
-        assert(this.boundOnExtensionAdded_));
+        assert(this.onExtensionAddedListener_));
     chrome.management.onUninstalled.removeListener(
-        assert(this.boundOnExtensionRemoved_));
+        assert(this.onExtensionRemovedListener_));
     chrome.management.onDisabled.removeListener(
-        assert(this.boundOnExtensionDisabled_));
+        assert(this.onExtensionDisabledListener_));
   },
 
   /**
-   * Reference to the bound listener, such that it can be removed on detach.
-   * @private {Function}
+   * Event triggered by a device state enabled toggle.
+   * @param {!{detail: {enabled: boolean,
+   *                    type: chrome.networkingPrivate.NetworkType}}} event
+   * @private
    */
-  boundOnExtensionAdded_: null,
-
-  /**
-   * Reference to the bound listener, such that it can be removed on detach.
-   * @private {Function}
-   */
-  boundOnExtensionRemoved_: null,
-
-  /**
-   * Reference to the bound listener, such that it can be removed on detach.
-   * @private {Function}
-   */
-  boundOnExtensionDisabled_: null,
+  onDeviceEnabledToggled_: function(event) {
+    if (event.detail.enabled)
+      this.networkingPrivate.enableNetworkType(event.detail.type);
+    else
+      this.networkingPrivate.disableNetworkType(event.detail.type);
+  },
 
   /**
    * @param {!{detail: !CrOnc.NetworkStateProperties}} event
    * @private
    */
   onShowDetail_: function(event) {
     var params = new URLSearchParams;
     params.append('guid', event.detail.GUID);
     params.append('type', event.detail.Type);
     if (event.detail.Name)
@@ skipping 120 matching lines @@
   },
 
   /**
    * @param {!chrome.networkingPrivate.ThirdPartyVPNProperties} provider
    * @return {string}
    */
   getAddThirdParrtyVpnLabel_: function(provider) {
     return this.i18n('internetAddThirdPartyVPN', provider.ProviderName);
   }
 });