fasta: Cache source bytes to ensure we use the same bytes for outline and bodies, Gives also around…

fasta: Cache source bytes to ensure we use the same bytes for outline and bodies, Gives also around 2.5%

Running fasta on dart2js sources shows no significant RSS memory
increase (within flakiness range).

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/72cd2a06f6682b2d1c05114e7d1703f0e85aac18

[kustermann, 2017-02-23 11:55:26]

kustermann@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-02-23 12:01:15]

Thank you.

Did you try caching the tokens instead?

[kustermann, 2017-02-23 12:09:41]

On 2017/02/23 12:01:15, ahe wrote:
> Thank you.
> 
> Did you try caching the tokens instead?

Yes, it takes more time due to GC pressure.

Action item:
* measure how this affects testing.dart
* do not cache bytes if we are just building an outline: Yes.

[ahe, 2017-02-23 12:42:07]

lgtm

[kustermann, 2017-02-24 16:32:37]

Description was changed from

==========
fasta: Cache source bytes to ensure we use the same bytes for outline and
bodies, Gives also around 2.5%

Running fasta on dart2js sources shows no significant RSS memory
increase (within flakiness range).
==========

to

==========
fasta: Cache source bytes to ensure we use the same bytes for outline and
bodies, Gives also around 2.5%

Running fasta on dart2js sources shows no significant RSS memory
increase (within flakiness range).

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/72cd2a06f6682b2d1c05114e7d1703f0e85aac18
==========

[kustermann, 2017-02-24 16:32:38]

Committed patchset #1 (id:1) manually as
72cd2a06f6682b2d1c05114e7d1703f0e85aac18 (presubmit successful).