Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm

Issue 2709563002: [tab_grid] Hack-in border for active tab. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm
diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm
index 8e02a69e54fa4982cfff8f0a98d406dc4bf071c8..abf9f5cbfd41f3fccd1d484b3dbed89cf44fd559 100644
--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm
+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm
@@ -13,38 +13,22 @@
#endif
namespace {
-const CGFloat kCornerRadius = 4.0;
-const CGFloat kSelectedBorderWidth = 2.0;
+const CGFloat kSelectedBorderCornerRadius = 8.0f;
+const CGFloat kSelectedBorderWidth = 4.0f;
}
@implementation TabGridTabCell
-@synthesize label = _label;
-
- (instancetype)initWithFrame:(CGRect)frame {
if ((self = [super initWithFrame:frame])) {
- self.contentView.layer.cornerRadius = kCornerRadius;
- self.selectedBackgroundView.layer.cornerRadius = kCornerRadius;
+ self.selectedBackgroundView = [[UIView alloc] init];
+ self.selectedBackgroundView.backgroundColor = [UIColor blackColor];
+ self.selectedBackgroundView.layer.cornerRadius =
+ kSelectedBorderCornerRadius;
self.selectedBackgroundView.layer.borderWidth = kSelectedBorderWidth;
- self.selectedBackgroundView.layer.borderColor = [UIColor blueColor].CGColor;
+ self.selectedBackgroundView.layer.borderColor = self.tintColor.CGColor;
self.selectedBackgroundView.transform = CGAffineTransformScale(
- self.selectedBackgroundView.transform, 1.05, 1.05);
-
- _label = [[UILabel alloc] initWithFrame:CGRectZero];
- _label.translatesAutoresizingMaskIntoConstraints = NO;
- _label.numberOfLines = 1;
- _label.textAlignment = NSTextAlignmentCenter;
- [self.contentView addSubview:_label];
- [NSLayoutConstraint activateConstraints:@[
- [_label.centerYAnchor
- constraintEqualToAnchor:self.contentView.centerYAnchor],
- [_label.leadingAnchor
- constraintEqualToAnchor:self.contentView.layoutMarginsGuide
- .leadingAnchor],
- [_label.trailingAnchor
- constraintEqualToAnchor:self.contentView.layoutMarginsGuide
- .trailingAnchor],
- ]];
+ self.selectedBackgroundView.transform, 1.08, 1.08);
}
return self;
}

Powered by Google App Engine
This is Rietveld 408576698