ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm - Issue 2709563002: [tab_grid] Hack-in border for active tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm

Issue 2709563002: [tab_grid] Hack-in border for active tab. (Closed)

Patch Set: [tab_grid] Hack-in border for active tab. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm ('K') | « ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm ('k') | ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm

diff --git a/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm b/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm

index da2519be894d603afb72fa4253c554b113ffc214..6c5e0a6255bf88ebf1bb29a66ae5e98fb5a8d39b 100644

--- a/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm

+++ b/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm

@@ -268,6 +268,14 @@ void FillVectorWithHashesUsingDistantSession(

nil);

}

+#pragma mark - UICollectionViewDelegate methods

+- (BOOL)collectionView:(UICollectionView*)collectionView

marq (ping after 24h) 2017/02/23 11:04:30 Definitely not worth adding this code just to keep

edchin 2017/02/23 17:41:54 Agreed! Your suggestion is very elegant.

+ shouldSelectItemAtIndexPath:(NSIndexPath*)indexPath {

+ // Prevent user selection of items.

+ return NO;

#pragma mark - SessionCellDelegate

- (TabSwitcherCache*)tabSwitcherCache {