Network traffic annotation added to chrome_omnibox_navigation_observer.

chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.h"
 
 #include "chrome/browser/autocomplete/shortcuts_backend_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/intranet_redirect_detector.h"
 #include "chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h"
 #include "components/omnibox/browser/shortcuts_backend.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "net/base/load_flags.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request.h"
 
 
 // Helpers --------------------------------------------------------------------
 
 namespace {
 
 // HTTP 2xx, 401, and 407 all indicate that the target address exists.
 bool ResponseCodeIndicatesSuccess(int response_code) {
@@ skipping 23 matching lines @@
     const base::string16& text,
     const AutocompleteMatch& match,
     const AutocompleteMatch& alternate_nav_match)
     : text_(text),
       match_(match),
       alternate_nav_match_(alternate_nav_match),
       shortcuts_backend_(ShortcutsBackendFactory::GetForProfile(profile)),
       load_state_(LOAD_NOT_SEEN),
       fetch_state_(FETCH_NOT_COMPLETE) {
   if (alternate_nav_match_.destination_url.is_valid()) {
+    net::NetworkTrafficAnnotationTag traffic_annotation =
+        net::DefineNetworkTrafficAnnotation("...", R"(
+          semantics {
+            sender: "..."

[Peter Kasting, 2017/02/24 03:06:33]

omnibox

[Ramin Halavati, 2017/02/24 07:38:51]

Done.

+            description: "..."

[Peter Kasting, 2017/02/24 03:06:33]

Certain omnibox inputs, e.g. single words, may either be search queries or
attempts to navigate to intranet hostnames.  When such a hostname is not in the
user's history, a background request is made to see if it is navigable.  If so,
the browser will display a prompt on the search results page asking if the user
wished to navigate instead of searching.

[Ramin Halavati, 2017/02/24 07:38:52]

Done.

+            trigger: "..."

[Peter Kasting, 2017/02/24 03:06:33]

User attempts to search for a string that is plausibly a navigable hostname but
is not in the local history.

[Ramin Halavati, 2017/02/24 07:38:51]

Done.

+            data: "..."

[Peter Kasting, 2017/02/24 03:06:33]

None.  However, the hostname itself is a string the user searched for, and thus
can expose data about the user's searches.

[Ramin Halavati, 2017/02/24 07:38:51]

Done.

+            destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[Peter Kasting, 2017/02/24 03:06:34]

WEBSITE

[Ramin Halavati, 2017/02/24 07:38:51]

Done.

+          }
+          policy {
+            cookies_allowed: false/true

[Peter Kasting, 2017/02/24 03:06:33]

true

[Ramin Halavati, 2017/02/24 07:38:52]

Done.

+            cookies_store: "..."

[Peter Kasting, 2017/02/24 03:06:33]

I'm not sure.  The actual request context is on line 145-6:

content::BrowserContext::GetDefaultStoragePartition(controller->GetBrowserContext())->GetURLRequestContext());

What context is that?  The user context?  That's what I'd expect.

[Ramin Halavati, 2017/02/24 07:38:51]

Done.

+            setting: "..."

[Peter Kasting, 2017/02/24 03:06:33]

NA

[Ramin Halavati, 2017/02/24 07:38:51]

Done.

+            policy {
+              [POLICY_NAME] {
+                policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+                value: ...
+              }
+            }

[Peter Kasting, 2017/02/24 03:06:33]

The closest policy we have for this is DefaultSearchProviderEnabled -- if you
disable default search, users can't search, so they can't hit this.

This is a very large hammer for admins to use. 
https://bugs.chromium.org/p/chromium/issues/detail?id=81226 is about providing a
more fine-grained policy and seems to have enough requests from the public that
I think we should do it.

I don't know what that means we should do fin this CL.

[Ramin Halavati, 2017/02/24 07:38:51]

Done.

+            policy_exception_justification: "..."
+          })");
     fetcher_ = net::URLFetcher::Create(alternate_nav_match_.destination_url,
-                                       net::URLFetcher::HEAD, this);
+                                       net::URLFetcher::HEAD, this,
+                                       traffic_annotation);
     fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES);
     fetcher_->SetStopOnRedirect(true);
   }
   // We need to start by listening to AllSources, since we don't know which tab
   // the navigation might occur in.
   registrar_.Add(this, content::NOTIFICATION_NAV_ENTRY_PENDING,
                  content::NotificationService::AllSources());
 }
 
 ChromeOmniboxNavigationObserver::~ChromeOmniboxNavigationObserver() {}
@@ skipping 102 matching lines @@
     OnAllLoadingFinished();  // deletes |this|!
 }
 
 void ChromeOmniboxNavigationObserver::OnAllLoadingFinished() {
   if (fetch_state_ == FETCH_SUCCEEDED) {
     AlternateNavInfoBarDelegate::Create(
         web_contents(), text_, alternate_nav_match_, match_.destination_url);
   }
   delete this;
 }