extensions/browser/api/cast_channel/cast_message_util.h - Issue 2709523008: [Cast Channel] Add support for nonce challenge to Cast channel authentication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_message_util.h

Issue 2709523008: [Cast Channel] Add support for nonce challenge to Cast channel authentication. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_message_util.h

diff --git a/extensions/browser/api/cast_channel/cast_message_util.h b/extensions/browser/api/cast_channel/cast_message_util.h

index b14b737a5c93b99398e28bea74be27f87919e637..03d7c93af95a8b187e3f1965151954bee81c78c7 100644

--- a/extensions/browser/api/cast_channel/cast_message_util.h

+++ b/extensions/browser/api/cast_channel/cast_message_util.h

@@ -33,7 +33,8 @@ std::string CastMessageToString(const CastMessage& message_proto);

std::string AuthMessageToString(const DeviceAuthMessage& message);

// Fills |message_proto| appropriately for an auth challenge request message.

-void CreateAuthChallengeMessage(CastMessage* message_proto);

+// Uses the challenge |nonce|.

+void CreateAuthChallengeMessage(CastMessage* message_proto, std::string nonce);

mark a. foltz 2017/02/27 23:04:32 const std::string&

ryanchung 2017/03/01 20:09:47 Done.

// Returns whether the given message is an auth handshake message.

bool IsAuthMessage(const CastMessage& message);