[Cast Channel] Add support for nonce challenge to Cast channel authentication.

extensions/browser/api/cast_channel/cast_socket.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_CAST_CHANNEL_CAST_SOCKET_H_
 #define EXTENSIONS_BROWSER_API_CAST_CHANNEL_CAST_SOCKET_H_
 
 #include <stdint.h>
 
 #include <queue>
@@ skipping 25 matching lines @@
 class SSLClientSocket;
 class StreamSocket;
 class TCPClientSocket;
 class TransportSecurityState;
 class X509Certificate;
 }
 
 namespace extensions {
 namespace api {
 namespace cast_channel {
+class AuthContext;
 class CastMessage;
 class Logger;
 struct LastErrors;
 
 // Cast device capabilities.
 enum CastDeviceCapability {
   NONE = 0,
   VIDEO_OUT = 1 << 0,
   VIDEO_IN = 1 << 1,
   AUDIO_OUT = 1 << 2,
@@ skipping 91 matching lines @@
   // |logger|: Log of cast channel events.
   CastSocketImpl(const std::string& owner_extension_id,
                  const net::IPEndPoint& ip_endpoint,
                  ChannelAuthType channel_auth,
                  net::NetLog* net_log,
                  const base::TimeDelta& connect_timeout,
                  bool keep_alive,
                  const scoped_refptr<Logger>& logger,
                  uint64_t device_capabilities);
 
+  // For test-only.
+  // This constructor allows for setting a custom AuthContext.
+  CastSocketImpl(const std::string& owner_extension_id,
+                 const net::IPEndPoint& ip_endpoint,
+                 ChannelAuthType channel_auth,
+                 net::NetLog* net_log,
+                 const base::TimeDelta& connect_timeout,
+                 bool keep_alive,
+                 const scoped_refptr<Logger>& logger,
+                 uint64_t device_capabilities,
+                 std::unique_ptr<AuthContext> auth_context);

[mark a. foltz, 2017/03/10 00:47:23]

const AuthContext&

[ryanchung, 2017/03/10 02:10:27]

Done.

+
   // Ensures that the socket is closed.
   ~CastSocketImpl() override;
 
   // CastSocket interface.
   void Connect(std::unique_ptr<CastTransport::Delegate> delegate,
                base::Callback<void(ChannelError)> callback) override;
   CastTransport* transport() const override;
   void Close(const net::CompletionCallback& callback) override;
   const net::IPEndPoint& ip_endpoint() const override;
   int id() const override;
@@ skipping 146 matching lines @@
   // Owned ptr to the underlying TCP socket.
   std::unique_ptr<net::TCPClientSocket> tcp_socket_;
 
   // Owned ptr to the underlying SSL socket.
   std::unique_ptr<net::SSLClientSocket> socket_;
 
   // Certificate of the peer. This field may be empty if the peer
   // certificate is not yet fetched.
   scoped_refptr<net::X509Certificate> peer_cert_;
 
+  // The challenge context for the current connection.
+  std::unique_ptr<AuthContext> auth_context_;

[mark a. foltz, 2017/03/10 00:47:23]

const AuthContext

GUID is a short string and not worth passing ownership of IMO.

[ryanchung, 2017/03/10 02:10:27]

Done.

+
   // Reply received from the receiver to a challenge request.
   std::unique_ptr<CastMessage> challenge_reply_;
 
   // Callback invoked when the socket is connected or fails to connect.
   base::Callback<void(ChannelError)> connect_callback_;
 
   // Callback invoked by |connect_timeout_timer_| to cancel the connection.
   base::CancelableClosure connect_timeout_callback_;
 
   // Duration to wait before timing out.
@@ skipping 46 matching lines @@
   // information.
   AuthTransportDelegate* auth_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(CastSocketImpl);
 };
 }  // namespace cast_channel
 }  // namespace api
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_CAST_CHANNEL_CAST_SOCKET_H_