telemetry/telemetry/internal/platform/profiler/v8_profiler.py - Issue 2709523005: [Telemetry] Switch RunShellCommand clients to check_return=True

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/profiler/v8_profiler.py

Issue 2709523005: [Telemetry] Switch RunShellCommand clients to check_return=True (Closed)

Patch Set: revert change in chown command Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/platform/profiler/v8_profiler.py

diff --git a/telemetry/telemetry/internal/platform/profiler/v8_profiler.py b/telemetry/telemetry/internal/platform/profiler/v8_profiler.py

index 6a86e2935a423d385192939008ee14fa261dbbd4..b2d930f07df25c1969f0df1205c3584e1ca0c21d 100644

--- a/telemetry/telemetry/internal/platform/profiler/v8_profiler.py

+++ b/telemetry/telemetry/internal/platform/profiler/v8_profiler.py

@@ -40,7 +40,7 @@ class V8Profiler(profiler.Profiler):

host_output_file = '%s.log' % self._output_path

self._browser_backend.device.PullFile(output_file, host_output_file)

# Clean the device

- self._browser_backend.device.RunShellCommand('rm %s' % output_file)

+ self._browser_backend.device.RemovePath(output_file)

output_file = host_output_file

print 'V8 profile saved as %s' % output_file

print 'To view, open in ' \

« no previous file with comments | « telemetry/telemetry/internal/platform/profiler/tcpdump_profiler.py ('k') | no next file » | no next file with comments »