telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler_helper.py - Issue 2709523005: [Telemetry] Switch RunShellCommand clients to check_return=True

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler_helper.py

Issue 2709523005: [Telemetry] Switch RunShellCommand clients to check_return=True (Closed)

Patch Set: revert change in chown command Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/platform/android_platform_backend.py ('k') | telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler_helper.py

diff --git a/telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler_helper.py b/telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler_helper.py

index 83adc5980c442c1db81e6fe8e70b542b976d4a01..77e23141a2b920bbe1b34807bd80616553556900 100644

--- a/telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler_helper.py

+++ b/telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler_helper.py

@@ -28,5 +28,6 @@ def InstallOnDevice(device, profiler_binary):

device_binary_path = GetDevicePath(profiler_binary)

device.PushChangedFiles([(host_path, device_binary_path)])

- device.RunShellCommand('chmod 777 ' + device_binary_path)

+ device.RunShellCommand(

+ ['chmod', '777', device_binary_path], check_return=True)

return True