telemetry/telemetry/internal/backends/chrome/android_browser_backend.py - Issue 2709523005: [Telemetry] Switch RunShellCommand clients to check_return=True

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

Issue 2709523005: [Telemetry] Switch RunShellCommand clients to check_return=True (Closed)

Patch Set: revert change in chown command Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/core/android_action_runner.py ('k') | telemetry/telemetry/internal/platform/android_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

index ac5bba26f28c9cc0a1f5182d2c88e6f84ab8586a..763f9655f51de9e1e7a7381d9c2e20eaa4c6b96e 100644

--- a/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

@@ -73,7 +73,7 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

self.platform_backend.StopApplication(self._backend_settings.package)

def Start(self):

- self.device.RunShellCommand('logcat -c')

+ self.device.adb.Logcat(clear=True)

if self.browser_options.startup_url:

url = self.browser_options.startup_url

elif self.browser_options.profile_dir: