[Telemetry] Switch RunShellCommand clients to check_return=True

telemetry/telemetry/internal/platform/profiler/perf_profiler.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import re
 import signal
 import subprocess
 import sys
@@ skipping 74 matching lines @@
     if self._is_android:
       cmd_prefix = [
           browser_backend.device.adb.GetAdbPath(),
           '-s', browser_backend.device.adb.GetDeviceSerial(),
           'shell', perf_binary]
       perf_args += _PERF_OPTIONS_ANDROID
       output_file = os.path.join('/sdcard', 'perf_profiles',
                                  os.path.basename(output_file))
       self._device_output_file = output_file
       browser_backend.device.RunShellCommand(
-          'mkdir -p ' + os.path.dirname(self._device_output_file))
-      browser_backend.device.RunShellCommand(
-          'rm -f ' + self._device_output_file)
+          ['mkdir', '-p', os.path.dirname(self._device_output_file)],
+          check_return=True)
+      browser_backend.device.RemovePath(self._device_output_file, force=True)
     else:
       cmd_prefix = [perf_binary]
     perf_args += ['--output', output_file] + _PERF_OPTIONS
     self._proc = subprocess.Popen(cmd_prefix + perf_args,
         stdout=self._tmp_output_file, stderr=subprocess.STDOUT)
 
   def CollectProfile(self):
     if ('renderer' in self._output_file and
         not self._is_android and
         not self._platform_backend.GetCommandLine(self._pid)):
@@ skipping 140 matching lines @@
       if len(fields) != 5:
         continue
       period = int(fields[1])
       function = fields[4].partition(' ')[2]
       function = re.sub('<.*>', '', function)  # Strip template params.
       function = re.sub('[(].*[)]', '', function)  # Strip function params.
       period_by_function[function] = period
       if len(period_by_function) == number:
         break
     return period_by_function