Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: net/dns/host_resolver.h

Issue 2709393007: Add back "default address family" to HostResolver (Closed)
Patch Set: another link to bug Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/dns/host_resolver.cc » ('j') | net/dns/host_resolver_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/host_resolver.h
diff --git a/net/dns/host_resolver.h b/net/dns/host_resolver.h
index fe38138f5c6934da06aa4788edfc1b3739460263..ba4b608ea2f417a3116549a8e5502f826b7faf47 100644
--- a/net/dns/host_resolver.h
+++ b/net/dns/host_resolver.h
@@ -213,6 +213,15 @@ class NET_EXPORT HostResolver {
const PersistCallback& persist_callback,
std::unique_ptr<const base::Value> old_data);
+ // Sets the default AddressFamily to use when requests have left it
+ // unspecified. For example, this could be used to restrict resolution
+ // results to AF_INET by passing in ADDRESS_FAMILY_IPV4, or to
+ // AF_INET6 by passing in ADDRESS_FAMILY_IPV6. This is used only to disable
+ // IPv6 in Cronet, and can be removed when support for the option is no longer
+ // needed. See http://crbug.com/696569.
+ virtual void SetDefaultAddressFamily(AddressFamily address_family) {}
xunjieli 2017/02/27 15:41:38 Please add a NOTREACHED() here. Mentioning Cronet
mgersh 2017/02/28 16:49:06 Done.
+ virtual AddressFamily GetDefaultAddressFamily() const;
+
// Creates a HostResolver implementation that queries the underlying system.
// (Except if a unit-test has changed the global HostResolverProc using
// ScopedHostResolverProc to intercept requests to the system).
« no previous file with comments | « no previous file | net/dns/host_resolver.cc » ('j') | net/dns/host_resolver_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698