content/browser/android/content_view_render_view.cc - Issue 270933002: Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_render_view.cc

Issue 270933002: Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: contentviewrenderview: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_render_view.h ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_render_view.cc

diff --git a/content/browser/android/content_view_render_view.cc b/content/browser/android/content_view_render_view.cc

index 9f5ed314178425320c4e6c8516cdaa882ee75d2b..efda29d7640121d264285afc0c8ae3d20288e59f 100644

--- a/content/browser/android/content_view_render_view.cc

+++ b/content/browser/android/content_view_render_view.cc

@@ -127,15 +127,6 @@ jboolean ContentViewRenderView::Composite(JNIEnv* env, jobject obj) {

return buffers_swapped_during_composite_;

}

-jboolean ContentViewRenderView::CompositeToBitmap(JNIEnv* env, jobject obj,

- jobject java_bitmap) {

- gfx::JavaBitmap bitmap(java_bitmap);

- if (!compositor_ || bitmap.format() != ANDROID_BITMAP_FORMAT_RGBA_8888)

- return false;

- return compositor_->CompositeAndReadback(bitmap.pixels(),

- gfx::Rect(bitmap.size()));

void ContentViewRenderView::SetOverlayVideoMode(

JNIEnv* env, jobject obj, bool enabled) {

compositor_->SetHasTransparentBackground(enabled);