Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 270933002: Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, enne (OOO), piman
Visibility:
Public.

Description

Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback. The CompositeAndReadback is going away, and this method is thought to be unused. Make the method just fail and return false. R=aelias, tedchoc@chromium.org BUG=371592 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269448

Patch Set 1 #

Patch Set 2 : contentviewrenderview: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M content/browser/android/content_view_render_view.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_view_render_view.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 1 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
danakj
6 years, 7 months ago (2014-05-08 22:40:36 UTC) #1
Ted C
On 2014/05/08 22:40:36, danakj wrote: This is only used in ContentViewRenderView.java and isn't exposed. So, ...
6 years, 7 months ago (2014-05-08 22:44:34 UTC) #2
danakj
Thanks for writing that out in full for me. PTAL
6 years, 7 months ago (2014-05-08 22:46:54 UTC) #3
Ted C
lgtm
6 years, 7 months ago (2014-05-08 22:48:07 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-08 22:48:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/270933002/20001
6 years, 7 months ago (2014-05-08 22:55:51 UTC) #6
commit-bot: I haz the power
Change committed as 269448
6 years, 7 months ago (2014-05-09 22:51:36 UTC) #7
danakj
6 years, 7 months ago (2014-05-12 22:16:33 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/286513002/ by danakj@chromium.org.

The reason for reverting is: This is possibly breaking android telemetry pixel
tests as per https://code.google.com/p/chromium/issues/detail?id=372562.

Powered by Google App Engine
This is Rietveld 408576698