[Android WebView] Split out WebView-parts of MinidumpUploaderTest

[Android WebView] Split out WebView-parts of MinidumpUploaderTest

To componentize MinidumpUploaderTest we first need to split out any
WebView-specific tests.
Split tests related to MinidumpUploaderImpl into several files -
one for CrashReceiverService, and one for the WebView-specific parts of
MinidumpUploaderImpl and its interaction with CrashReceiverService.

BUG=692448

[gsennton, 2017-02-23 14:48:47]

gsennton@chromium.org changed reviewers:
+ isherman@chromium.org, tobiasjs@chromium.org

[gsennton, 2017-02-23 14:48:48]

Toby for the entire review.

Ilya FYI

ptal :)

https://codereview.chromium.org/2709323004/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/crash/WebViewMinidumpUploaderTest.java
(right):

https://codereview.chromium.org/2709323004/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/crash/WebViewMinidumpUploaderTest.java:136:
assertEquals(expectedFileContent, readEntireFile(uploadedFiles[0]));
This is the only change I did except just moving code here: 
try {
    assertEquals(expectedFileContent, readEntireFile(uploadedFiles[0]));
} catch (IOException e) {
    throw new RuntimeException(e);
}

====>

assertEquals(expectedFileContent, readEntireFile(uploadedFiles[0]));

https://codereview.chromium.org/2709323004/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/crash/WebViewMinidumpUploaderTest.java:170:
if (expectedFirstFileContent.equals(actualFileContent0)) {
Same as above here - remove try-catch-rethrow of IOException.

[Ilya Sherman, 2017-02-28 04:00:04]

Thanks, Gustav!

https://codereview.chromium.org/2709323004/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/crash/WebViewMinidumpUploaderTest.java
(right):

https://codereview.chromium.org/2709323004/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/crash/WebViewMinidumpUploaderTest.java:30:
public class WebViewMinidumpUploaderTest extends MinidumpUploaderTest {
FWIW, I'd prefer not to use inheritance like this for tests, and instead to
factor out some test utility classes and methods if need be.  Inheritance can
easily hide a lot of complexity; and it's nice if tests are as simple and
self-contained as possible.  (Inheriting from really generic instrumentation
frameworks is a bit different, as they are designed with very simple APIs in
mind.)

[gsennton, 2017-02-28 16:30:05]

https://codereview.chromium.org/2709323004/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/crash/WebViewMinidumpUploaderTest.java
(right):

https://codereview.chromium.org/2709323004/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/crash/WebViewMinidumpUploaderTest.java:30:
public class WebViewMinidumpUploaderTest extends MinidumpUploaderTest {
On 2017/02/28 04:00:04, Ilya Sherman wrote:
> FWIW, I'd prefer not to use inheritance like this for tests, and instead to
> factor out some test utility classes and methods if need be.  Inheritance can
> easily hide a lot of complexity; and it's nice if tests are as simple and
> self-contained as possible.  (Inheriting from really generic instrumentation
> frameworks is a bit different, as they are designed with very simple APIs in
> mind.)

Alright, makes sense :) (I'll update this to do so).

[Tobias Sargeant, 2017-02-28 22:36:30]

Would uploading this CL with --similarity={some-small-number} (as Ilya did for
his refactoring patch) make this easier to read?

[gsennton, 2017-04-17 16:24:33]

Description was changed from

==========
[Android WebView] Split out WebView-parts of MinidumpUploaderTest

To componentize MinidumpUploaderTest we first need to split out any
WebView-specific tests.
Split tests related to MinidumpUploaderImpl into several files -
one for CrashReceiverService, and one for the WebView-specific parts of
MinidumpUploaderImpl and its interaction with CrashReceiverService.

BUG=692448
==========

to

==========
[Android WebView] Split out WebView-parts of MinidumpUploaderTest

To componentize MinidumpUploaderTest we first need to split out any
WebView-specific tests.
Split tests related to MinidumpUploaderImpl into several files -
one for CrashReceiverService, and one for the WebView-specific parts of
MinidumpUploaderImpl and its interaction with CrashReceiverService.

BUG=692448
==========

[gsennton, 2017-04-17 16:24:56]

On 2017/02/28 22:36:30, Tobias Sargeant wrote:
> Would uploading this CL with --similarity={some-small-number} (as Ilya did for
> his refactoring patch) make this easier to read?

Probably :), I'm closing this in favour of a couple of other CLs.