third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp - Issue 2709263003: Removed FrameHost::settings()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp

Issue 2709263003: Removed FrameHost::settings() (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp

diff --git a/third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp b/third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp

index 190f62b3e34faca3ad1e56931ac84d46c534e880..79de80a44d09f504646c4236d327b9ec277a7043 100644

--- a/third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp

+++ b/third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp

@@ -125,7 +125,7 @@ Storage* DOMWindowStorage::localStorage(ExceptionState& exceptionState) const {

}

// FIXME: Seems this check should be much higher?

FrameHost* host = document->frameHost();

- if (!host || !host->settings().getLocalStorageEnabled())

+ if (!host || !host->page().settings().getLocalStorageEnabled())

return nullptr;

StorageArea* storageArea =

StorageNamespace::localStorageArea(document->getSecurityOrigin());