Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameHost.h

Issue 2709263003: Removed FrameHost::settings() (Closed)
Patch Set: Switched if statement to use page Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 class BrowserControls; 43 class BrowserControls;
44 class ChromeClient; 44 class ChromeClient;
45 class ConsoleMessageStorage; 45 class ConsoleMessageStorage;
46 class Deprecation; 46 class Deprecation;
47 class EventHandlerRegistry; 47 class EventHandlerRegistry;
48 class OverscrollController; 48 class OverscrollController;
49 class Page; 49 class Page;
50 struct PageScaleConstraints; 50 struct PageScaleConstraints;
51 class PageScaleConstraintsSet; 51 class PageScaleConstraintsSet;
52 class Settings;
53 class TopDocumentRootScrollerController; 52 class TopDocumentRootScrollerController;
54 class UseCounter; 53 class UseCounter;
55 class VisualViewport; 54 class VisualViewport;
56 55
57 // FrameHost is the set of global data shared between multiple frames 56 // FrameHost is the set of global data shared between multiple frames
58 // and is provided by the embedder to each frame when created. 57 // and is provided by the embedder to each frame when created.
59 // FrameHost currently corresponds to the Page object in core/page 58 // FrameHost currently corresponds to the Page object in core/page
60 // however the concept of a Page is moving up out of Blink. 59 // however the concept of a Page is moving up out of Blink.
61 // In an out-of-process iframe world, a single Page may have 60 // In an out-of-process iframe world, a single Page may have
62 // multiple frames in different process, thus Page becomes a 61 // multiple frames in different process, thus Page becomes a
63 // browser-level concept and Blink core/ only knows about its LocalFrame (and 62 // browser-level concept and Blink core/ only knows about its LocalFrame (and
64 // FrameHost). Separating Page from the rest of core/ through this indirection 63 // FrameHost). Separating Page from the rest of core/ through this indirection
65 // allows us to slowly refactor Page without breaking the rest of core. 64 // allows us to slowly refactor Page without breaking the rest of core.
65 // TODO(sashab): Merge FrameHost back into Page. crbug.com/688614
66 class CORE_EXPORT FrameHost final 66 class CORE_EXPORT FrameHost final
67 : public GarbageCollectedFinalized<FrameHost> { 67 : public GarbageCollectedFinalized<FrameHost> {
68 WTF_MAKE_NONCOPYABLE(FrameHost); 68 WTF_MAKE_NONCOPYABLE(FrameHost);
69 69
70 public: 70 public:
71 static FrameHost* create(Page&); 71 static FrameHost* create(Page&);
72 ~FrameHost(); 72 ~FrameHost();
73 73
74 // Careful: This function will eventually be removed.
75 Page& page(); 74 Page& page();
76 const Page& page() const; 75 const Page& page() const;
77 76
78 Settings& settings();
79 const Settings& settings() const;
80
81 ChromeClient& chromeClient(); 77 ChromeClient& chromeClient();
82 const ChromeClient& chromeClient() const; 78 const ChromeClient& chromeClient() const;
83 79
84 UseCounter& useCounter(); 80 UseCounter& useCounter();
85 const UseCounter& useCounter() const; 81 const UseCounter& useCounter() const;
86 82
87 Deprecation& deprecation(); 83 Deprecation& deprecation();
88 const Deprecation& deprecation() const; 84 const Deprecation& deprecation() const;
89 85
90 // Corresponds to pixel density of the device where this Page is 86 // Corresponds to pixel density of the device where this Page is
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 const Member<TopDocumentRootScrollerController> 146 const Member<TopDocumentRootScrollerController>
151 m_globalRootScrollerController; 147 m_globalRootScrollerController;
152 148
153 AtomicString m_overrideEncoding; 149 AtomicString m_overrideEncoding;
154 int m_subframeCount; 150 int m_subframeCount;
155 }; 151 };
156 152
157 } // namespace blink 153 } // namespace blink
158 154
159 #endif // FrameHost_h 155 #endif // FrameHost_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.cpp ('k') | third_party/WebKit/Source/core/frame/FrameHost.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698