Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: src/inspector/debugger-script.js

Issue 2709263002: [inspector] use BREAK_POSITION_ALIGNED for breakpoints (Closed)
Patch Set: little testcfg tuning Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | test/inspector/debugger/get-possible-breakpoints.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 return result; 101 return result;
102 } 102 }
103 103
104 /** 104 /**
105 * @param {!ExecutionState} execState 105 * @param {!ExecutionState} execState
106 * @param {!BreakpointInfo} info 106 * @param {!BreakpointInfo} info
107 * @return {string|undefined} 107 * @return {string|undefined}
108 */ 108 */
109 DebuggerScript.setBreakpoint = function(execState, info) 109 DebuggerScript.setBreakpoint = function(execState, info)
110 { 110 {
111 var breakId = Debug.setScriptBreakPointById(info.sourceID, info.lineNumber, info.columnNumber, info.condition, undefined, Debug.BreakPositionAlignment.State ment); 111 var breakId = Debug.setScriptBreakPointById(info.sourceID, info.lineNumber, info.columnNumber, info.condition, undefined, Debug.BreakPositionAlignment.Break Position);
112 var locations = Debug.findBreakPointActualLocations(breakId); 112 var locations = Debug.findBreakPointActualLocations(breakId);
113 if (!locations.length) 113 if (!locations.length)
114 return undefined; 114 return undefined;
115 info.lineNumber = locations[0].line; 115 info.lineNumber = locations[0].line;
116 info.columnNumber = locations[0].column; 116 info.columnNumber = locations[0].column;
117 return breakId.toString(); 117 return breakId.toString();
118 } 118 }
119 119
120 /** 120 /**
121 * @param {!ExecutionState} execState 121 * @param {!ExecutionState} execState
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 case ScopeType.Global: 489 case ScopeType.Global:
490 case ScopeType.With: 490 case ScopeType.With:
491 result = scopeObject; 491 result = scopeObject;
492 break; 492 break;
493 } 493 }
494 return result; 494 return result;
495 } 495 }
496 496
497 return DebuggerScript; 497 return DebuggerScript;
498 })(); 498 })();
OLDNEW
« no previous file with comments | « src/debug/debug.cc ('k') | test/inspector/debugger/get-possible-breakpoints.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698