chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm - Issue 2709213005: [Mac] Add XPC alerts to GetDisplayedNotifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

Issue 2709213005: [Mac] Add XPC alerts to GetDisplayedNotifications (Closed)

Patch Set: Rebase after making the whole flow async in a different patch Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_platform_bridge_mac.mm ('K') | « chrome/browser/notifications/notification_platform_bridge_mac.mm ('k') | chrome/browser/notifications/stub_alert_dispatcher_mac.h » ('j') | chrome/browser/notifications/stub_alert_dispatcher_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

diff --git a/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm b/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

index f4be0cfdf27a369a85ee79cdbfa54b8e82fdb3ab..293ca79d0cc6c7ffe3c50a4562ff3ef90bfd73d5 100644

--- a/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

+++ b/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

@@ -272,7 +272,8 @@ TEST_F(NotificationPlatformBridgeMacTest, TestGetDisplayed) {

std::unique_ptr<Notification> notification = CreateBanner(

"Title", "Context", "https://gmail.com", "Button 1", nullptr);

std::unique_ptr<NotificationPlatformBridgeMac> bridge(

- new NotificationPlatformBridgeMac(notification_center(), nil));

+ new NotificationPlatformBridgeMac(notification_center(),

+ alert_dispatcher()));

EXPECT_EQ(0u, [[notification_center() deliveredNotifications] count]);

bridge->Display(NotificationCommon::PERSISTENT, "notification_id",

"profile_id", false, *notification);

@@ -290,7 +291,8 @@ TEST_F(NotificationPlatformBridgeMacTest, TestGetDisplayedUnknownProfile) {