[Mac] Add XPC alerts to GetDisplayedNotifications

chrome/browser/notifications/notification_display_service.h

Index: chrome/browser/notifications/notification_display_service.h
diff --git a/chrome/browser/notifications/notification_display_service.h b/chrome/browser/notifications/notification_display_service.h
index 003274a60c48c6039f9c85e73ecacb2a94440c4f..d0420ba3c7b93f70daf3041c27f544de016c81a8 100644
--- a/chrome/browser/notifications/notification_display_service.h
+++ b/chrome/browser/notifications/notification_display_service.h
@@ -21,7 +21,6 @@ class Profile;
 // instance can be retrieved through the NotificationDisplayServiceFactory.
 //
 // TODO(peter): Add a NotificationHandler mechanism for registering listeners.
-// TODO(miguelg): Remove the SupportsNotificationCenter method.
 class NotificationDisplayService : public KeyedService {
  public:
   NotificationDisplayService() {}
@@ -40,6 +39,11 @@ class NotificationDisplayService : public KeyedService {
   // notifications and stores them in |*notification_ids| when possible.
   virtual bool GetDisplayed(std::set<std::string>* notifications) const = 0;
 
+  // Async version of the GetDisplayed
+  // TODO(miguelg) Remove the sync version once all paths have been migrated.
+  virtual void GetDisplayedAsync(

[Peter Beverloo, 2017/02/24 16:12:23]

It would be much easier if you would change this around.

First update GetDisplayed() to take a callback and change the callsites to match
this. (Just immediately posting to it.)

Then update the implementation where necessary (Mac) to provide the added
functionality.

Please do drop the "Async" from the method name regardless which path you take.
The fact that it returns void and takes a callback implies that clearly enough.

[Miguel Garcia, 2017/03/22 22:00:06]

Yeah Async was temporary, I am however if I should add something like
"OnIOThread" to indicate that the callback is posted in said thread.

Re: the order, will send a CL doing that first. I did it this way because I was
more interested in getting feedback for the mac pieces.


On 2017/02/24 16:12:23, Peter Beverloo (OOO - Mar 6th) wrote:

+      const NotificationCommon::NotificationResultCallback& callback) const = 0;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(NotificationDisplayService);
 };