Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: chrome/browser/notifications/alert_dispatcher_mac.h

Issue 2709213005: [Mac] Add XPC alerts to GetDisplayedNotifications (Closed)
Patch Set: - Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/alert_dispatcher_mac.h
diff --git a/chrome/browser/notifications/alert_dispatcher_mac.h b/chrome/browser/notifications/alert_dispatcher_mac.h
index ee2744c29e183d68a1c4ee6e462dbfa76bed14fd..9456ef0e0bf0459e66231c9cc62d91c5d41697c1 100644
--- a/chrome/browser/notifications/alert_dispatcher_mac.h
+++ b/chrome/browser/notifications/alert_dispatcher_mac.h
@@ -7,6 +7,8 @@
#import <Foundation/Foundation.h>
+#include "chrome/browser/notifications/notification_common.h"
+
// Interface to communicate with the Alert XPC service.
@protocol AlertDispatcher<NSObject>
@@ -20,6 +22,11 @@
// Close all notifications.
- (void)closeAllNotifications;
+// Get currently displayed notifications.
+- (void)getDisplayedAlertIds:(NSString*)profileId
Robert Sesek 2017/02/24 22:38:05 Maybe getDisplayedAlertsForProfileId:withLocalNoti
Miguel Garcia 2017/03/22 22:00:06 Done, but shouldn't it be withCallback or andCallb
Robert Sesek 2017/04/03 16:51:24 Methods with a lot of parameters get too wordy if
Miguel Garcia 2017/04/04 12:21:26 Acknowledged.
+ withLocalNotifications:(NSArray*)localNotifications
+ withCallback:
+ (NotificationCommon::NotificationResultCallback)callback;
@end
#endif // CHROME_BROWSER_NOTIFICATIONS_ALERT_DISPATCHER_MAC_H_

Powered by Google App Engine
This is Rietveld 408576698