[Mac] Add XPC alerts to GetDisplayedNotifications

chrome/browser/notifications/notification_display_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_
 
 #include <set>
 #include <string>
 
 #include "base/macros.h"
 #include "chrome/browser/notifications/notification_common.h"
 #include "components/keyed_service/core/keyed_service.h"
 
 class Notification;
 class Profile;
 
 // Profile-bound service that enables notifications to be displayed and
 // interacted with on the user's screen, orthogonal of whether this
 // functionality is provided by the browser or by the operating system. An
 // instance can be retrieved through the NotificationDisplayServiceFactory.
 //
 // TODO(peter): Add a NotificationHandler mechanism for registering listeners.
-// TODO(miguelg): Remove the SupportsNotificationCenter method.
 class NotificationDisplayService : public KeyedService {
  public:
   NotificationDisplayService() {}
   ~NotificationDisplayService() override {}
 
   // Displays the |notification| identified by |notification_id|.
   virtual void Display(NotificationCommon::Type notification_type,
                        const std::string& notification_id,
                        const Notification& notification) = 0;
 
   // Closes the notification identified by |notification_id|.
   virtual void Close(NotificationCommon::Type notification_type,
                      const std::string& notification_id) = 0;
 
   // Returns whether the implementation can retrieve a list of currently visible
   // notifications and stores them in |*notification_ids| when possible.
   virtual bool GetDisplayed(std::set<std::string>* notifications) const = 0;
 
+  // Async version of the GetDisplayed
+  // TODO(miguelg) Remove the sync version once all paths have been migrated.
+  virtual void GetDisplayedAsync(

[Peter Beverloo, 2017/02/24 16:12:23]

It would be much easier if you would change this around.

First update GetDisplayed() to take a callback and change the callsites to match
this. (Just immediately posting to it.)

Then update the implementation where necessary (Mac) to provide the added
functionality.

Please do drop the "Async" from the method name regardless which path you take.
The fact that it returns void and takes a callback implies that clearly enough.

[Miguel Garcia, 2017/03/22 22:00:06]

Yeah Async was temporary, I am however if I should add something like
"OnIOThread" to indicate that the callback is posted in said thread.

Re: the order, will send a CL doing that first. I did it this way because I was
more interested in getting feedback for the mac pieces.


On 2017/02/24 16:12:23, Peter Beverloo (OOO - Mar 6th) wrote:

+      const NotificationCommon::NotificationResultCallback& callback) const = 0;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(NotificationDisplayService);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_