[BlobStorage] Better net error reporting for pre-broken blobs

storage/browser/blob/blob_reader.cc

Index: storage/browser/blob/blob_reader.cc
diff --git a/storage/browser/blob/blob_reader.cc b/storage/browser/blob/blob_reader.cc
index 5584036d348d50a96e31964f6ff41237893b7a7a..1e447c4713b2d7efc77e8863b1ffd77d8377bd62 100644
--- a/storage/browser/blob/blob_reader.cc
+++ b/storage/browser/blob/blob_reader.cc
@@ -75,8 +75,12 @@ BlobReader::BlobReader(
       file_task_runner_(file_task_runner),
       net_error_(net::OK),
       weak_factory_(this) {
-  if (blob_handle && !blob_handle->IsBroken()) {
-    blob_handle_.reset(new BlobDataHandle(*blob_handle));
+  if (blob_handle) {
+    if (!blob_handle->IsBroken()) {

[pwnall, 2017/02/22 23:33:50]

How about flipping the if / else, so no (implicit) double negative shows up when
thinking about condition gating the else branch?

[dmurph, 2017/02/22 23:43:25]

Good idea, thanks.

+      blob_handle_.reset(new BlobDataHandle(*blob_handle));
+    } else {
+      net_error_ = ConvertBlobErrorToNetError(blob_handle->GetBlobStatus());
+    }
   }
 }