Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Issue 2709193002: WorkerLoaderProxy: stop accessing cross-thread execution context (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.h
diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.h b/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
index ea4bb1b69c93a3a9c7d86de128b944315fe249c0..d32b805083aff54781de70d8e7cc339fdb433adf 100644
--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
@@ -151,17 +151,15 @@ class WebSharedWorkerImpl final : public WorkerReportingProxy,
// WorkerLoaderProxyProvider
void postTaskToLoader(const WebTraceLocation&,
- std::unique_ptr<ExecutionContextTask>) override;
+ std::unique_ptr<WTF::CrossThreadClosure>) override;
void postTaskToWorkerGlobalScope(
const WebTraceLocation&,
std::unique_ptr<WTF::CrossThreadClosure>) override;
+ ExecutionContext* getLoaderExecutionContext() override;
// 'shadow page' - created to proxy loading requests from the worker.
// Will be accessed by worker thread when posting tasks.
- //
- // TODO: it is undesirable to keep a cross-thread reference to this
- // document; avoid reaching into the document when posting.
- CrossThreadPersistent<ExecutionContext> m_loadingDocument;
+ Persistent<ExecutionContext> m_loadingDocument;
WebView* m_webView;
Persistent<WebLocalFrameImpl> m_mainFrame;
bool m_askedToTerminate;
« no previous file with comments | « third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp ('k') | third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698