Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

Issue 2709193002: WorkerLoaderProxy: stop accessing cross-thread execution context (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h
diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h
index 2a8c516aad54c8ecf90d1dc66b3694ff48b8c0cd..78856bc64e0419c1e5b711fab20dd003487ab719 100644
--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h
+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h
@@ -102,10 +102,11 @@ class WebEmbeddedWorkerImpl final : public WebEmbeddedWorker,
// WorkerLoaderProxyProvider
void postTaskToLoader(const WebTraceLocation&,
- std::unique_ptr<ExecutionContextTask>) override;
+ std::unique_ptr<WTF::CrossThreadClosure>) override;
void postTaskToWorkerGlobalScope(
const WebTraceLocation&,
std::unique_ptr<WTF::CrossThreadClosure>) override;
+ ExecutionContext* getLoaderExecutionContext() override;
WebEmbeddedWorkerStartData m_workerStartData;
@@ -137,10 +138,7 @@ class WebEmbeddedWorkerImpl final : public WebEmbeddedWorker,
// are guaranteed to exist while this object is around.
WebView* m_webView;
- // Accessed cross-thread when worker thread posts tasks to the parent.
- //
- // TODO: avoid reaching into the local frame object when posting.
- CrossThreadPersistent<WebLocalFrameImpl> m_mainFrame;
+ Persistent<WebLocalFrameImpl> m_mainFrame;
bool m_loadingShadowPage;
bool m_askedToTerminate;

Powered by Google App Engine
This is Rietveld 408576698