third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h - Issue 2709193002: WorkerLoaderProxy: stop accessing cross-thread execution context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h

Issue 2709193002: WorkerLoaderProxy: stop accessing cross-thread execution context (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h ('K') | « third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h ('k') | third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h

diff --git a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h

index 01ea434896350639fb8a0d892891f4a7d01a45ad..e46f676e3a3e433b5c17a64afaa26064c612a15f 100644

--- a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h

+++ b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h

@@ -160,11 +160,11 @@ class WorkerWebSocketChannel final : public WebSocketChannel {

void disconnect();

void connectOnMainThread(std::unique_ptr<SourceLocation>,

+ PassRefPtr<WorkerLoaderProxy>,

tzik 2017/02/23 05:46:14 PassRefPtr will be removed soon. Can we use RefPtr

kinuko 2017/02/23 07:35:30 Sure. Yay for the deprecation! Done.

WorkerThreadLifecycleContext*,

const KURL&,

const String& protocol,

- WebSocketChannelSyncHelper*,

- ExecutionContext*);

+ WebSocketChannelSyncHelper*);

// Returns null when |disconnect| has already been called.

WebSocketChannelClient* client() { return m_client; }