android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java - Issue 2709163008: [Android Crash Reporting] Componentize MinidumpUploadImpl.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java

Issue 2709163008: [Android Crash Reporting] Componentize MinidumpUploadImpl.java (Closed)

Patch Set: Finished rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/BUILD.gn ('k') | android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java

diff --git a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java

index 8640034cc72135bca8bdaf05a54748cee121a1fc..e2b4adf3f9a94e71beb18b2cee3d1157014a6620 100644

--- a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java

+++ b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java

@@ -10,6 +10,7 @@ import org.chromium.android_webview.command_line.CommandLineUtil;

import org.chromium.base.ContextUtils;

import org.chromium.components.minidump_uploader.MinidumpUploadJobService;

import org.chromium.components.minidump_uploader.MinidumpUploader;

+import org.chromium.components.minidump_uploader.MinidumpUploaderImpl;

/**

* Class that interacts with the Android JobScheduler to upload Minidumps at appropriate times.

@@ -31,6 +32,6 @@ public class AwMinidumpUploadJobService extends MinidumpUploadJobService {

// Ensure we can use ContextUtils later on (from the minidump_uploader component).

ContextUtils.initApplicationContext(this.getApplicationContext());

- return new MinidumpUploaderImpl(this);

+ return new MinidumpUploaderImpl(new AwMinidumpUploaderDelegate(this));

}