[Android Crash Reporting] Componentize MinidumpUploadImpl.java

components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java

Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploader.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
similarity index 23%
copy from components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploader.java
copy to components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
index 7264aeb3660bc6ba0caf87f80208a812dda3b305..9eceae026515557deaadb38bf6712324b6651789 100644
--- a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploader.java
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
@@ -4,27 +4,30 @@
 
 package org.chromium.components.minidump_uploader;
 
+import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
+
+import java.io.File;
+
 /**
- * Interface for uploading minidumps.
+ * Interface for embedder-specific implementations for uploading minidumps.
  */
-public interface MinidumpUploader {
+public interface MinidumpUploaderDelegate {
     /**
-     * Try to upload all the minidumps in the crash directory.
-     * This method will be called on the UI thread of our JobService.
-     * @param uploadsFinishedCallback a callback that will be called when the uploading is finished
-     * (whether or not all of the uploads succeeded).
+     * Creates the directory in which the embedder will store its minidumps.
+     * @return A reference to the created directory, or null if the creation failed.
      */
-    void uploadAllMinidumps(UploadsFinishedCallback uploadsFinishedCallback);
+    File createCrashDir();
 
     /**
-     * Cancel the current set of uploads.
-     * @return whether there are still uploads to be done.
+     * Creates the permission manager used to evaluate whether uploading should be allowed.
+     * @return The permission manager.
      */
-    boolean cancelUploads();
+    CrashReportingPermissionManager createCrashReportingPermissionManager();
 
     /**
-     * Provides an interface for the callback that will be called if all uploads are finished before
-     * they are canceled.
+     * Performs any pre-work necessary for uploading minidumps, then calls the |startUploads|

[gsennton, 2017/02/27 18:54:56]

I think in java docs you would write {@param startUploads} instead of
|startUploads| ?

[Ilya Sherman, 2017/02/28 03:54:13]

Done.

+     * continuation to initiate uploading the minidumps.
+     * @param startUploads The continuation to call once any necessary pre-work is completed.
      */
-    public interface UploadsFinishedCallback { public void uploadsFinished(boolean reschedule); }
+    void prepareToUploadMinidumps(Runnable startUploads);
 }