android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java - Issue 2709163008: [Android Crash Reporting] Componentize MinidumpUploadImpl.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

Issue 2709163008: [Android Crash Reporting] Componentize MinidumpUploadImpl.java (Closed)

Patch Set: Finish the componentization Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java ('K') | « android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java ('k') | android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

diff --git a/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

index ecd8c0a607c5a08adf8cb70a40801887a1bcc6a1..fa55e1ab16fe59c5ad50b0d09bacbde54967bff5 100644

--- a/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

+++ b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

@@ -177,7 +177,7 @@ public class CrashReceiverService extends Service {

}

/**

- * Create the directory in which WebView wlll store its minidumps.

+ * Create the directory in which WebView will store its minidumps.

* WebView needs a crash directory different from Chrome's to ensure Chrome's and WebView's

* minidump handling won't clash in cases where both Chrome and WebView are provided by the

* same app (Monochrome).