Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Side by Side Diff: pkg/front_end/test/subpackage_relationships_test.dart

Issue 2709123003: fasta: Let "lib/src/fasta/builder" depend on "lib/src/fasta/util" (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io'; 6 import 'dart:io';
7 7
8 import 'package:front_end/compiler_options.dart'; 8 import 'package:front_end/compiler_options.dart';
9 import 'package:front_end/dependency_grapher.dart'; 9 import 'package:front_end/dependency_grapher.dart';
10 import 'package:path/path.dart' as pathos; 10 import 'package:path/path.dart' as pathos;
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 'lib/src/fasta/source', 53 'lib/src/fasta/source',
54 ]), 54 ]),
55 'lib/src/fasta/bin': new SubpackageRules(allowedDependencies: [ 55 'lib/src/fasta/bin': new SubpackageRules(allowedDependencies: [
56 'lib/src/fasta', 56 'lib/src/fasta',
57 ]), 57 ]),
58 'lib/src/fasta/builder': new SubpackageRules(allowedDependencies: [ 58 'lib/src/fasta/builder': new SubpackageRules(allowedDependencies: [
59 'lib/src/fasta', 59 'lib/src/fasta',
60 'lib/src/fasta/dill', 60 'lib/src/fasta/dill',
61 'lib/src/fasta/parser', 61 'lib/src/fasta/parser',
62 'lib/src/fasta/source', 62 'lib/src/fasta/source',
63 'lib/src/fasta/util',
63 ]), 64 ]),
64 'lib/src/fasta/dill': new SubpackageRules(allowedDependencies: [ 65 'lib/src/fasta/dill': new SubpackageRules(allowedDependencies: [
65 'lib/src/fasta', 66 'lib/src/fasta',
66 'lib/src/fasta/kernel', 67 'lib/src/fasta/kernel',
67 ]), 68 ]),
68 'lib/src/fasta/kernel': new SubpackageRules(allowedDependencies: [ 69 'lib/src/fasta/kernel': new SubpackageRules(allowedDependencies: [
69 'lib/src/fasta', 70 'lib/src/fasta',
70 'lib/src/fasta/builder', 71 'lib/src/fasta/builder',
71 'lib/src/fasta/dill', 72 'lib/src/fasta/dill',
72 'lib/src/fasta/parser', 73 'lib/src/fasta/parser',
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 problem('Uri $src is inside package:front_end but is not in any known ' 232 problem('Uri $src is inside package:front_end but is not in any known '
232 'subpackage'); 233 'subpackage');
233 } else if (!subpackageRules[subpackage].allowSubdirs && 234 } else if (!subpackageRules[subpackage].allowSubdirs &&
234 pathWithinSubpackage.contains('/')) { 235 pathWithinSubpackage.contains('/')) {
235 problem('Uri $src is in a subfolder of $subpackage, but that ' 236 problem('Uri $src is in a subfolder of $subpackage, but that '
236 'subpackage does not allow dart files in subdirectories.'); 237 'subpackage does not allow dart files in subdirectories.');
237 } 238 }
238 return subpackage; 239 return subpackage;
239 } 240 }
240 } 241 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698