Flip vertical-rl coordinates for Legacy compat

third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_block_node.h"
 
 #include "core/layout/LayoutBlockFlow.h"
 #include "core/layout/api/LineLayoutAPIShim.h"
 #include "core/layout/line/InlineIterator.h"
 #include "core/layout/ng/layout_ng_block_flow.h"
@@ skipping 14 matching lines @@
 namespace {
 
 // Copies data back to the legacy layout tree for a given child fragment.
 void FragmentPositionUpdated(const NGPhysicalFragment& fragment) {
   LayoutBox* layout_box = toLayoutBox(fragment.GetLayoutObject());
   if (!layout_box)
     return;
 
   DCHECK(layout_box->parent()) << "Should be called on children only.";
 
-  layout_box->setX(fragment.LeftOffset());
+  // LegacyLayout flips vertical-rl horizontal coordinates before paint.
+  // NGLayout flips X location for LegacyLayout compatibility.
+  LayoutBlock* containing_block = layout_box->containingBlock();
+  if (containing_block->styleRef().isFlippedBlocksWritingMode()) {
+    LayoutUnit container_width = containing_block->logicalHeight();

[cbiesinger, 2017/02/24 21:48:10]

I'd do size().width() instead of logicalHeight() since we use physical
coordinates in the rest of this function

[atotic, 2017/02/24 22:41:15]

done

+    layout_box->setX(container_width - fragment.LeftOffset() -
+                     fragment.Width());
+  } else {
+    layout_box->setX(fragment.LeftOffset());
+  }
   layout_box->setY(fragment.TopOffset());
 }
 
 // Similar to FragmentPositionUpdated but for floats.
 // - Updates layout object's geometric information.
 // - Creates legacy FloatingObject and attached it to the provided parent.
 void FloatingObjectPositionedUpdated(NGFloatingObject* ng_floating_object,
                                      LayoutBox* parent) {
   NGPhysicalBoxFragment* box_fragment =
       toNGPhysicalBoxFragment(ng_floating_object->fragment.get());
@@ skipping 314 matching lines @@
 // Save static position for legacy AbsPos layout.
 void NGBlockNode::SaveStaticOffsetForLegacy(const NGLogicalOffset& offset) {
   DCHECK(layout_box_);
   DCHECK(layout_box_->isOutOfFlowPositioned());
   DCHECK(layout_box_->layer());
   layout_box_->layer()->setStaticBlockPosition(offset.block_offset);
   layout_box_->layer()->setStaticInlinePosition(offset.inline_offset);
 }
 
 }  // namespace blink