Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/core/events/PointerEventFactory.cpp

Issue 2709033002: Disable the DCHECK on id because of some flaky tests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/events/PointerEventFactory.cpp
diff --git a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
index 164a6cb7ad8231ddd80467740dd5b82a53d7f8c3..43aace2c5cec559902fcec8a7a561b32072cc9c9 100644
--- a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
+++ b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
@@ -273,7 +273,10 @@ PointerEvent* PointerEventFactory::create(
if (pointerEventName == EventTypeNames::pointermove) {
HeapVector<Member<PointerEvent>> coalescedPointerEvents;
for (const auto& coalescedMouseEvent : coalescedMouseEvents) {
- DCHECK_EQ(mouseEvent.id, coalescedMouseEvent.id);
+ // TODO(crbug.com/694742): We will set the id from low-level OS events
+ // and enable this DCHECK again.
+ // DCHECK_EQ(mouseEvent.id, coalescedMouseEvent.id);
+
// TODO(crbug.com/684292): We need further investigation of why the
// following DCHECK fails.
// DCHECK_EQ(mouseEvent.pointerType, coalescedMouseEvent.pointerType);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698