Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 270903002: Add defensive code for now to RenderLayerRepainter to prevent squashing crashes (Closed)

Created:
6 years, 7 months ago by chrishtr
Modified:
6 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Add defensive code for now to RenderLayerRepainter to prevent squashing crashes when removing certain kinds of layers. BUG=370410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173659

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed one defensive check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M Source/core/rendering/RenderLayerRepainter.cpp View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
chrishtr
6 years, 7 months ago (2014-05-08 16:44:29 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/270903002/diff/1/Source/core/rendering/RenderLayerRepainter.cpp File Source/core/rendering/RenderLayerRepainter.cpp (right): https://codereview.chromium.org/270903002/diff/1/Source/core/rendering/RenderLayerRepainter.cpp#newcode212 Source/core/rendering/RenderLayerRepainter.cpp:212: if (RenderLayer* layer = m_renderer.layer()) { I don't ...
6 years, 7 months ago (2014-05-08 16:59:34 UTC) #2
chrishtr
https://codereview.chromium.org/270903002/diff/1/Source/core/rendering/RenderLayerRepainter.cpp File Source/core/rendering/RenderLayerRepainter.cpp (right): https://codereview.chromium.org/270903002/diff/1/Source/core/rendering/RenderLayerRepainter.cpp#newcode212 Source/core/rendering/RenderLayerRepainter.cpp:212: if (RenderLayer* layer = m_renderer.layer()) { On 2014/05/08 16:59:34, ...
6 years, 7 months ago (2014-05-08 17:02:23 UTC) #3
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 7 months ago (2014-05-08 17:02:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/270903002/20001
6 years, 7 months ago (2014-05-08 17:03:24 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 18:18:01 UTC) #6
Message was sent while issue was closed.
Change committed as 173659

Powered by Google App Engine
This is Rietveld 408576698