Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

Issue 2709013007: Allow flow thread portion logical bottom to be above its logical top. (Closed)
Patch Set: Add clarifying comment in logicalHeightInFlowThread() Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
index 21083bc7fbe2443d0340ab40c2e81e8f6b7f9e0c..393400ad54a903deb368a1e189c1de27e40b098c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
@@ -495,7 +495,13 @@ LayoutMultiColumnSet* LayoutMultiColumnFlowThread::columnSetAtBlockOffset(
walker = walker->nextSiblingMultiColumnSet()) {
if (!walker->isPageLogicalHeightKnown())
continue;
- if (walker->logicalTopInFlowThread() == offset)
+ if (pageBoundaryRule == AssociateWithFormerPage) {
+ if (walker->logicalTopInFlowThread() < offset &&
+ walker->logicalBottomInFlowThread() >= offset)
+ return walker;
+ }
+ if (walker->logicalTopInFlowThread() <= offset &&
+ walker->logicalBottomInFlowThread() > offset)
return walker;
break;
}
@@ -896,13 +902,8 @@ void LayoutMultiColumnFlowThread::skipColumnSpanner(
LayoutMultiColumnSpannerPlaceholder* placeholder =
layoutObject->spannerPlaceholder();
LayoutBox* previousColumnBox = placeholder->previousSiblingMultiColumnBox();
- if (previousColumnBox && previousColumnBox->isLayoutMultiColumnSet()) {
- LayoutMultiColumnSet* columnSet = toLayoutMultiColumnSet(previousColumnBox);
- // Negative margins may cause this.
- if (logicalTopInFlowThread < columnSet->logicalTopInFlowThread())
- logicalTopInFlowThread = columnSet->logicalTopInFlowThread();
- columnSet->endFlow(logicalTopInFlowThread);
- }
+ if (previousColumnBox && previousColumnBox->isLayoutMultiColumnSet())
+ toLayoutMultiColumnSet(previousColumnBox)->endFlow(logicalTopInFlowThread);
LayoutBox* nextColumnBox = placeholder->nextSiblingMultiColumnBox();
if (nextColumnBox && nextColumnBox->isLayoutMultiColumnSet()) {
LayoutMultiColumnSet* nextSet = toLayoutMultiColumnSet(nextColumnBox);

Powered by Google App Engine
This is Rietveld 408576698