Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm

Issue 2709013002: [ios clean] Rename removeChildViewController -> detachChildViewController (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm
diff --git a/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm b/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm
index 71fb6058b2b95311b86e66baffdaa319c84f39e4..06c398cd6690b55e565fe2842574400e125a39d2 100644
--- a/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm
+++ b/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm
@@ -96,7 +96,7 @@ CGFloat kTabStripHeight = 200.0f;
if (self.contentViewController == contentViewController)
return;
if ([self isViewLoaded]) {
- [self removeChildViewController:self.contentViewController];
+ [self detachChildViewController:self.contentViewController];
[self addChildViewController:contentViewController
toSubview:self.contentView];
}
@@ -107,7 +107,7 @@ CGFloat kTabStripHeight = 200.0f;
if (self.toolbarViewController == toolbarViewController)
return;
if ([self isViewLoaded]) {
- [self removeChildViewController:self.toolbarViewController];
+ [self detachChildViewController:self.toolbarViewController];
[self addChildViewController:toolbarViewController
toSubview:self.toolbarView];
}
@@ -118,7 +118,7 @@ CGFloat kTabStripHeight = 200.0f;
if (self.tabStripViewController == tabStripViewController)
return;
if ([self isViewLoaded]) {
- [self removeChildViewController:self.tabStripViewController];
+ [self detachChildViewController:self.tabStripViewController];
[self addChildViewController:tabStripViewController
toSubview:self.tabStripView];
}
@@ -141,7 +141,7 @@ CGFloat kTabStripHeight = 200.0f;
[viewController didMoveToParentViewController:self];
}
-- (void)removeChildViewController:(UIViewController*)viewController {
+- (void)detachChildViewController:(UIViewController*)viewController {
if (viewController.parentViewController != self)
return;
[viewController willMoveToParentViewController:nil];
« no previous file with comments | « no previous file | ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698