[ios clean] Rename removeChildViewController -> detachChildViewController

ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ======                        New Architecture                         =====
 // =         This code is only used in the new iOS Chrome architecture.       =
 // ============================================================================
 
 #import "ios/clean/chrome/browser/ui/tab/tab_container_view_controller.h"
 
@@ skipping 16 matching lines @@
 
 @property(nonatomic, strong) Constraints* contentConstraintsWithToolbar;
 @property(nonatomic, strong) Constraints* contentConstraintsWithoutToolbar;
 @property(nonatomic, strong) Constraints* toolbarConstraints;
 
 // Cache for forwarding methods to child view controllers.
 @property(nonatomic, assign) SEL actionToForward;
 @property(nonatomic, weak) UIResponder* forwardingTarget;
 
 // Contained view controller utility methods.
-- (void)removeChildViewController:(UIViewController*)viewController;
+- (void)removeChildViewControllerFromParent:(UIViewController*)viewController;

[edchin, 2017/02/21 23:28:16]

This looks like the parameter is the parent, not the child VC. 

[edchin, 2017/02/22 00:34:46]

I suggest namespacing with a prefix. -(void)cr_removeChildViewController:

[marq (ping after 24h), 2017/02/22 09:13:44]

I agree. How about -detachChildViewController: ?, and a comment that
-removeChildViewController: is a private superclass method.

[justincohen, 2017/02/22 12:48:35]

Done.

 
 // Called after a new content view controller is set, but before
 // |-didMoveToParentViewController:| is called on that view controller.
 - (void)didAddContentViewController;
 
 // Called after a new toolbar view controller is set, but before
 // |-didMoveToParentViewController:| is called on that view controller.
 - (void)didAddToolbarViewController;
 
 // Methods to populate the constraint properties.
@@ skipping 18 matching lines @@
 #pragma mark - Public properties
 
 - (void)setContentViewController:(UIViewController*)contentViewController {
   if (self.contentViewController == contentViewController)
     return;
 
   // Remove the current content view controller, if any.
   [NSLayoutConstraint
       deactivateConstraints:self.contentConstraintsWithoutToolbar];
   [NSLayoutConstraint deactivateConstraints:self.contentConstraintsWithToolbar];
-  [self removeChildViewController:self.contentViewController];
+  [self removeChildViewControllerFromParent:self.contentViewController];
 
   // Add the new content view controller.
   [self addChildViewController:contentViewController];
   contentViewController.view.translatesAutoresizingMaskIntoConstraints = NO;
   [self.view addSubview:contentViewController.view];
   _contentViewController = contentViewController;
   [self didAddContentViewController];
   [self.view setNeedsUpdateConstraints];
   [self.contentViewController didMoveToParentViewController:self];
 }
 
 - (void)setToolbarViewController:(UIViewController*)toolbarViewController {
   if (self.toolbarViewController == toolbarViewController)
     return;
 
   // Remove the current toolbar view controller, if any.
   [NSLayoutConstraint deactivateConstraints:self.toolbarConstraints];
   [NSLayoutConstraint deactivateConstraints:self.contentConstraintsWithToolbar];
-  [self removeChildViewController:self.toolbarViewController];
+  [self removeChildViewControllerFromParent:self.toolbarViewController];
 
   // Add the new toolbar view controller.
   [self addChildViewController:toolbarViewController];
   toolbarViewController.view.translatesAutoresizingMaskIntoConstraints = NO;
   [self.view addSubview:toolbarViewController.view];
   _toolbarViewController = toolbarViewController;
   [self didAddToolbarViewController];
   [self.view setNeedsUpdateConstraints];
   [self.toolbarViewController didMoveToParentViewController:self];
 }
@@ skipping 88 matching lines @@
 
 - (id)forwardingTargetForSelector:(SEL)aSelector {
   if (aSelector == self.actionToForward) {
     return self.forwardingTarget;
   }
   return nil;
 }
 
 #pragma mark - Private methods
 
-- (void)removeChildViewController:(UIViewController*)viewController {
+- (void)removeChildViewControllerFromParent:(UIViewController*)viewController {
   if (viewController.parentViewController != self)
     return;
   [viewController willMoveToParentViewController:nil];
   [viewController.view removeFromSuperview];
   [viewController removeFromParentViewController];
 }
 
 - (void)didAddContentViewController {
   if (self.toolbarViewController) {
     [self updateContentConstraintsWithToolbar];
@@ skipping 106 matching lines @@
   self.toolbarConstraints = @[
     [toolbarView.bottomAnchor constraintEqualToAnchor:self.view.bottomAnchor],
     [toolbarView.heightAnchor constraintEqualToConstant:kToolbarHeight],
     [toolbarView.leadingAnchor constraintEqualToAnchor:self.view.leadingAnchor],
     [toolbarView.trailingAnchor
         constraintEqualToAnchor:self.view.trailingAnchor],
   ];
 }
 
 @end