Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-channel-rules.html

Issue 2708953003: Move task.describe descriptions to audit.define (Closed)
Patch Set: Address review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <html> 3 <html>
4 <head> 4 <head>
5 <script src="../../resources/testharness.js"></script> 5 <script src="../../resources/testharness.js"></script>
6 <script src="../../resources/testharnessreport.js"></script> 6 <script src="../../resources/testharnessreport.js"></script>
7 <script src="../resources/audit-util.js"></script> 7 <script src="../resources/audit-util.js"></script>
8 <script src="../resources/audit.js"></script> 8 <script src="../resources/audit.js"></script>
9 <script src="../resources/mixing-rules.js"></script> 9 <script src="../resources/mixing-rules.js"></script>
10 </head> 10 </head>
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 let mixingRules = mixingRulesList[m]; 206 let mixingRules = mixingRulesList[m];
207 for (let i = 0; i < connectionsList.length; ++i, ++testNumber) { 207 for (let i = 0; i < connectionsList.length; ++i, ++testNumber) {
208 checkTestResult( 208 checkTestResult(
209 buffer, testNumber, connectionsList[i], mixingRules.channelCount, 209 buffer, testNumber, connectionsList[i], mixingRules.channelCount,
210 mixingRules.channelCountMode, mixingRules.channelInterpretation, 210 mixingRules.channelCountMode, mixingRules.channelInterpretation,
211 should); 211 should);
212 } 212 }
213 } 213 }
214 } 214 }
215 215
216 audit.define('test', function(task, should) { 216 audit.define({
217 task.describe('Channel mixing rules for AudioNodes'); 217 label: 'test',
218 description: 'Channel mixing rules for AudioNodes'
219 }, function(task, should) {
218 220
219 // Create 8-channel offline audio context. Each test will render 8 221 // Create 8-channel offline audio context. Each test will render 8
220 // sample-frames starting at sample-frame position testNumber * 8. 222 // sample-frames starting at sample-frame position testNumber * 8.
221 let totalFrameLength = numberOfTests * singleTestFrameLength; 223 let totalFrameLength = numberOfTests * singleTestFrameLength;
222 context = new OfflineAudioContext( 224 context = new OfflineAudioContext(
223 renderNumberOfChannels, totalFrameLength, sampleRate); 225 renderNumberOfChannels, totalFrameLength, sampleRate);
224 226
225 // Set destination to discrete mixing. 227 // Set destination to discrete mixing.
226 context.destination.channelCount = renderNumberOfChannels; 228 context.destination.channelCount = renderNumberOfChannels;
227 context.destination.channelCountMode = 'explicit'; 229 context.destination.channelCountMode = 'explicit';
(...skipping 25 matching lines...) Expand all
253 }); 255 });
254 ; 256 ;
255 }); 257 });
256 258
257 audit.run(); 259 audit.run();
258 260
259 </script> 261 </script>
260 262
261 </body> 263 </body>
262 </html> 264 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698