Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: content/renderer/media/renderer_webaudiodevice_impl.h

Issue 2708933005: Fix WebAudio support for discrete channel layouts. (Closed)
Patch Set: Zero session_id. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/media/renderer_webaudiodevice_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_RENDERER_WEBAUDIODEVICE_IMPL_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_RENDERER_WEBAUDIODEVICE_IMPL_H_
6 #define CONTENT_RENDERER_MEDIA_RENDERER_WEBAUDIODEVICE_IMPL_H_ 6 #define CONTENT_RENDERER_MEDIA_RENDERER_WEBAUDIODEVICE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 17 matching lines...) Expand all
28 28
29 namespace content { 29 namespace content {
30 class CONTENT_EXPORT RendererWebAudioDeviceImpl 30 class CONTENT_EXPORT RendererWebAudioDeviceImpl
31 : NON_EXPORTED_BASE(public blink::WebAudioDevice), 31 : NON_EXPORTED_BASE(public blink::WebAudioDevice),
32 NON_EXPORTED_BASE(public media::AudioRendererSink::RenderCallback) { 32 NON_EXPORTED_BASE(public media::AudioRendererSink::RenderCallback) {
33 public: 33 public:
34 ~RendererWebAudioDeviceImpl() override; 34 ~RendererWebAudioDeviceImpl() override;
35 35
36 static RendererWebAudioDeviceImpl* Create( 36 static RendererWebAudioDeviceImpl* Create(
37 media::ChannelLayout layout, 37 media::ChannelLayout layout,
38 int channels,
38 const blink::WebAudioLatencyHint& latency_hint, 39 const blink::WebAudioLatencyHint& latency_hint,
39 blink::WebAudioDevice::RenderCallback* callback, 40 blink::WebAudioDevice::RenderCallback* callback,
40 int session_id, 41 int session_id,
41 const url::Origin& security_origin); 42 const url::Origin& security_origin);
42 43
43 // blink::WebAudioDevice implementation. 44 // blink::WebAudioDevice implementation.
44 void start() override; 45 void start() override;
45 void stop() override; 46 void stop() override;
46 double sampleRate() override; 47 double sampleRate() override;
47 int framesPerBuffer() override; 48 int framesPerBuffer() override;
48 49
49 // AudioRendererSink::RenderCallback implementation. 50 // AudioRendererSink::RenderCallback implementation.
50 int Render(base::TimeDelta delay, 51 int Render(base::TimeDelta delay,
51 base::TimeTicks delay_timestamp, 52 base::TimeTicks delay_timestamp,
52 int prior_frames_skipped, 53 int prior_frames_skipped,
53 media::AudioBus* dest) override; 54 media::AudioBus* dest) override;
54 55
55 void OnRenderError() override; 56 void OnRenderError() override;
56 57
57 void SetMediaTaskRunnerForTesting( 58 void SetMediaTaskRunnerForTesting(
58 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner); 59 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner);
59 60
61 const media::AudioParameters& get_sink_params_for_testing() {
62 return sink_params_;
63 }
64
60 protected: 65 protected:
61 // Callback to get output device params (for tests). 66 // Callback to get output device params (for tests).
62 using OutputDeviceParamsCallback = base::Callback<media::AudioParameters( 67 using OutputDeviceParamsCallback = base::Callback<media::AudioParameters(
63 int frame_id, 68 int frame_id,
64 int session_id, 69 int session_id,
65 const std::string& device_id, 70 const std::string& device_id,
66 const url::Origin& security_origin)>; 71 const url::Origin& security_origin)>;
67 72
68 // Callback get render frame ID for current context (for tests). 73 // Callback get render frame ID for current context (for tests).
69 using RenderFrameIdCallback = base::Callback<int()>; 74 using RenderFrameIdCallback = base::Callback<int()>;
70 75
71 RendererWebAudioDeviceImpl(media::ChannelLayout layout, 76 RendererWebAudioDeviceImpl(media::ChannelLayout layout,
77 int channels,
72 const blink::WebAudioLatencyHint& latency_hint, 78 const blink::WebAudioLatencyHint& latency_hint,
73 blink::WebAudioDevice::RenderCallback* callback, 79 blink::WebAudioDevice::RenderCallback* callback,
74 int session_id, 80 int session_id,
75 const url::Origin& security_origin, 81 const url::Origin& security_origin,
76 const OutputDeviceParamsCallback& device_params_cb, 82 const OutputDeviceParamsCallback& device_params_cb,
77 const RenderFrameIdCallback& render_frame_id_cb); 83 const RenderFrameIdCallback& render_frame_id_cb);
78 84
79 private: 85 private:
80 const scoped_refptr<base::SingleThreadTaskRunner>& GetMediaTaskRunner(); 86 const scoped_refptr<base::SingleThreadTaskRunner>& GetMediaTaskRunner();
81 87
(...skipping 25 matching lines...) Expand all
107 113
108 // Allow unit tests to set a custom MediaThreadTaskRunner. 114 // Allow unit tests to set a custom MediaThreadTaskRunner.
109 scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_; 115 scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
110 116
111 DISALLOW_COPY_AND_ASSIGN(RendererWebAudioDeviceImpl); 117 DISALLOW_COPY_AND_ASSIGN(RendererWebAudioDeviceImpl);
112 }; 118 };
113 119
114 } // namespace content 120 } // namespace content
115 121
116 #endif // CONTENT_RENDERER_MEDIA_RENDERER_WEBAUDIODEVICE_IMPL_H_ 122 #endif // CONTENT_RENDERER_MEDIA_RENDERER_WEBAUDIODEVICE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/media/renderer_webaudiodevice_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698