[Payments] Add timeout to the address_normalizer.

components/payments/address_normalizer_unittest.cc

Index: components/payments/address_normalizer_unittest.cc
diff --git a/components/payments/address_normalizer_unittest.cc b/components/payments/address_normalizer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8614659c33f484049d72b2fa068572c103d080b6
--- /dev/null
+++ b/components/payments/address_normalizer_unittest.cc
@@ -0,0 +1,178 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/payments/address_normalizer.h"
+
+#include "base/macros.h"
+#include "base/run_loop.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/test/scoped_task_scheduler.h"
+#include "components/autofill/core/browser/autofill_profile.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/libaddressinput/src/cpp/include/libaddressinput/null_storage.h"
+#include "third_party/libaddressinput/src/cpp/include/libaddressinput/source.h"
+#include "third_party/libaddressinput/src/cpp/include/libaddressinput/storage.h"
+#include "third_party/libaddressinput/src/cpp/test/testdata_source.h"
+
+namespace payments {
+

[please use gerrit instead, 2017/02/21 17:15:16]

nit: no newline.

[sebsg, 2017/02/21 18:30:59]

Done.

+namespace {
+
+using ::i18n::addressinput::NullStorage;
+using ::i18n::addressinput::Source;
+using ::i18n::addressinput::Storage;
+using ::i18n::addressinput::TestdataSource;

[please use gerrit instead, 2017/02/21 17:15:14]

Somone's been reading up on C++, I see. Good job! :-D

[sebsg, 2017/02/21 18:30:59]

Thanks :)

+
+// The requester of normalization for this test.
+class NormalizationDelegate : public AddressNormalizer::Delegate {
+ public:
+  NormalizationDelegate()
+      : normalized_called_(false), not_normalized_called_(false){};
+

[please use gerrit instead, 2017/02/21 17:15:16]

Need to override the destructor.

[sebsg, 2017/02/21 18:31:00]

Done.

+  void OnAddressNormalized(
+      const autofill::AutofillProfile& normalized_profile) override {
+    normalized_called_ = true;
+  }
+
+  void OnCouldNotNormalize(const autofill::AutofillProfile& profile) override {
+    not_normalized_called_ = true;
+  }
+
+  bool NormalizedCalled() { return normalized_called_; }

[please use gerrit instead, 2017/02/21 17:15:16]

nit: hacker_case for simple accessor.

[sebsg, 2017/02/21 18:31:00]

Done.

+
+  bool NotNormalizedCalled() { return not_normalized_called_; }

[please use gerrit instead, 2017/02/21 17:15:15]

ditto.

[sebsg, 2017/02/21 18:30:59]

Done.

+
+ private:
+  bool normalized_called_;
+  bool not_normalized_called_;
+};
+
+// Used to load region rules for this test.
+class ChromiumTestdataSource : public TestdataSource {

[please use gerrit instead, 2017/02/21 17:15:18]

Why not use TestdataSource as-is? One caveat is that you need to run the
components_unittests binary from chrome/ instead of chrome/src/ for
TestdataSource to find the test data file. That's what trybots do, by the way.

[Mathieu, 2017/02/21 17:40:43]

We could try, but I'm pretty sure this won't work on all bots.
Isolate/non-isolate both run things from separate dirs, and the hardcoded-ness
of TestDataSource's path does not play well with this. This is why I suggested
working around this issue.

[sebsg, 2017/02/21 18:30:59]

Acknowledged.

[sebsg, 2017/02/21 18:31:00]

Acknowledged.

+ public:
+  ChromiumTestdataSource() : TestdataSource(true) {}
+
+  // For this test, only load the rules for the "US".
+  void Get(const std::string& key, const Callback& data_ready) const override {
+    data_ready(
+        true, key,
+        new std::string("{\"data/US\": "
+                        "{\"id\":\"data/US\",\"key\":\"US\",\"name\":\"UNITED "
+                        "STATES\",\"lang\":\"en\",\"languages\":\"en\"}}"));
+  }
+};
+
+// A test subclass of the AddressNormalizer. Used to simulate rules not being
+// loaded.
+class TestAddressNormalizer : public AddressNormalizer {
+ public:
+  TestAddressNormalizer(std::unique_ptr<i18n::addressinput::Source> source,
+                        std::unique_ptr<i18n::addressinput::Storage> storage)
+      : AddressNormalizer(std::move(source), std::move(storage)),
+        should_load_rules_(true) {}

[please use gerrit instead, 2017/02/21 17:15:13]

Need to override the destructor.

[sebsg, 2017/02/21 18:31:00]

Done.

+
+  void ShouldLoadRules(bool should_load_rules) {
+    should_load_rules_ = should_load_rules;
+  }
+
+  void LoadRulesForRegion(const std::string& region_code) override {
+    if (should_load_rules_) {
+      AddressNormalizer::LoadRulesForRegion(region_code);
+    }
+  }
+
+ private:
+  bool should_load_rules_;
+};
+
+}  // namespace
+
+class AddressNormalizerTest : public testing::Test {
+ protected:
+  AddressNormalizerTest()
+      : normalizer_(new TestAddressNormalizer(
+            std::unique_ptr<Source>(new ChromiumTestdataSource),
+            std::unique_ptr<Storage>(new NullStorage))) {}
+
+  ~AddressNormalizerTest() override {}
+
+  const std::unique_ptr<TestAddressNormalizer> normalizer_;
+
+  base::test::ScopedTaskScheduler scoped_task_scheduler_;
+
+  DISALLOW_COPY_AND_ASSIGN(AddressNormalizerTest);

[please use gerrit instead, 2017/02/21 17:15:19]

This works only in a "private:" section.

[sebsg, 2017/02/21 18:30:59]

Done.

+};
+
+// Tests that rules are not loaded by default.
+TEST_F(AddressNormalizerTest, AreRulesLoadedForRegion_NotLoaded) {
+  EXPECT_FALSE(normalizer_->AreRulesLoadedForRegion("US"));
+}
+
+// Tests that the rules are loaded correctly.
+TEST_F(AddressNormalizerTest, AreRulesLoadedForRegion_Loaded) {
+  normalizer_->LoadRulesForRegion("US");
+  EXPECT_TRUE(normalizer_->AreRulesLoadedForRegion("US"));
+}
+
+// Tests that if the rules are loaded before the normalization is started, the
+// normalized profile will be returned to the delegate synchronously.
+TEST_F(AddressNormalizerTest, StartNormalization_RulesLoaded) {
+  NormalizationDelegate delegate;
+  AutofillProfile profile;
+
+  // Load the rules.
+  normalizer_->LoadRulesForRegion("US");
+  EXPECT_TRUE(normalizer_->AreRulesLoadedForRegion("US"));
+
+  // Start the normalization.
+  normalizer_->StartAddressNormalization(profile, "US", 0, &delegate);
+
+  // Since the rules are already loaded, the address should be normalized
+  // synchronously.
+  EXPECT_TRUE(delegate.NormalizedCalled());
+  EXPECT_FALSE(delegate.NotNormalizedCalled());
+}
+
+// Tests that if the rules are not loaded before the normalization and cannot be
+// loaded after, the address will not be normalized and the delegate will be
+// notified.
+TEST_F(AddressNormalizerTest, StartNormalization_RulesNotLoaded_WillNotLoad) {
+  NormalizationDelegate delegate;
+  AutofillProfile profile;
+
+  // Make sure the rules will not be loaded in the StartAddressNormalization
+  // call.
+  normalizer_->ShouldLoadRules(false);
+
+  // Start the normalization.
+  normalizer_->StartAddressNormalization(profile, "US", 0, &delegate);
+
+  // Let the timeout execute.
+  base::RunLoop().RunUntilIdle();
+
+  // Since the rules are never loaded and the timeout is 0, the delegate should
+  // get notified that the address could not be normalized.
+  EXPECT_FALSE(delegate.NormalizedCalled());
+  EXPECT_TRUE(delegate.NotNormalizedCalled());
+}
+
+// Tests that if the rules are not loaded before the call to
+// StartAddressNormalization, they will be loaded in the call.
+TEST_F(AddressNormalizerTest, StartNormalization_RulesNotLoaded_WillLoad) {
+  NormalizationDelegate delegate;
+  AutofillProfile profile;
+
+  // Start the normalization.
+  normalizer_->StartAddressNormalization(profile, "US", 0, &delegate);
+
+  // Even if the rules are not loaded before the call to
+  // StartAddressNormalization, they should get loaded in the call. Since our
+  // test source is synchronous, the normalization will happen synchronously
+  // too.
+  EXPECT_TRUE(normalizer_->AreRulesLoadedForRegion("US"));
+  EXPECT_TRUE(delegate.NormalizedCalled());
+  EXPECT_FALSE(delegate.NotNormalizedCalled());
+}
+
+}  // namespace payments