chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc - Issue 2708923013: Split ArcSessionManager::OnPrimaryUserProfilePrepared().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2708923013: Split ArcSessionManager::OnPrimaryUserProfilePrepared(). (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/arc/arc_session_manager_unittest.cc ('K') | « chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc » ('j') | chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

index fd07a7d3718885ec34d84f4d82540c14ddaab185..2bbd82e91a429b1036c193a0a68c2356a7d36a67 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

@@ -2136,15 +2136,9 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcAppPin) {

SendListOfArcApps();

EXPECT_EQ("AppList, Chrome, App1, App2", GetPinnedAppStatus());

- // Disable/Enable ARC should persist pin state.

+ // Opt-Out/Opt-In remove item from the shelf.

launcher_controller_->PinAppWithID(arc_app_id);

EXPECT_EQ("AppList, Chrome, App1, App2, Fake App 0", GetPinnedAppStatus());

- arc::ArcSessionManager::Get()->Shutdown();

hidehiko 2017/02/24 18:29:13 This is unexpected usage. No need to test.

- EXPECT_EQ("AppList, Chrome, App1, App2, Fake App 0", GetPinnedAppStatus());

- arc::ArcSessionManager::Get()->OnPrimaryUserProfilePrepared(profile());

- EXPECT_EQ("AppList, Chrome, App1, App2, Fake App 0", GetPinnedAppStatus());

- // Opt-Out/Opt-In remove item from the shelf.

EnableArc(false);

EXPECT_EQ("AppList, Chrome, App1, App2", GetPinnedAppStatus());

EnableArc(true);