Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Side by Side Diff: chrome/browser/chromeos/arc/arc_service_launcher.cc

Issue 2708923013: Split ArcSessionManager::OnPrimaryUserProfilePrepared(). (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/arc_session_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/arc/arc_service_launcher.h" 5 #include "chrome/browser/chromeos/arc/arc_service_launcher.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "base/threading/sequenced_worker_pool.h" 12 #include "base/threading/sequenced_worker_pool.h"
13 #include "chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.h" 13 #include "chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.h"
14 #include "chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bri dge.h" 14 #include "chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bri dge.h"
15 #include "chrome/browser/chromeos/arc/arc_auth_service.h" 15 #include "chrome/browser/chromeos/arc/arc_auth_service.h"
16 #include "chrome/browser/chromeos/arc/arc_session_manager.h" 16 #include "chrome/browser/chromeos/arc/arc_session_manager.h"
17 #include "chrome/browser/chromeos/arc/arc_util.h"
17 #include "chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_ bridge.h" 18 #include "chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_ bridge.h"
18 #include "chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_se rvice.h" 19 #include "chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_se rvice.h"
19 #include "chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_servic e.h" 20 #include "chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_servic e.h"
20 #include "chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.h " 21 #include "chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.h "
21 #include "chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h" 22 #include "chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h"
22 #include "chrome/browser/chromeos/arc/intent_helper/arc_settings_service.h" 23 #include "chrome/browser/chromeos/arc/intent_helper/arc_settings_service.h"
23 #include "chrome/browser/chromeos/arc/notification/arc_boot_error_notification.h " 24 #include "chrome/browser/chromeos/arc/notification/arc_boot_error_notification.h "
24 #include "chrome/browser/chromeos/arc/policy/arc_policy_bridge.h" 25 #include "chrome/browser/chromeos/arc/policy/arc_policy_bridge.h"
26 #include "chrome/browser/chromeos/arc/policy/arc_policy_util.h"
25 #include "chrome/browser/chromeos/arc/print/arc_print_service.h" 27 #include "chrome/browser/chromeos/arc/print/arc_print_service.h"
26 #include "chrome/browser/chromeos/arc/process/arc_process_service.h" 28 #include "chrome/browser/chromeos/arc/process/arc_process_service.h"
27 #include "chrome/browser/chromeos/arc/tts/arc_tts_service.h" 29 #include "chrome/browser/chromeos/arc/tts/arc_tts_service.h"
28 #include "chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.h" 30 #include "chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.h"
29 #include "chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.h" 31 #include "chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.h"
30 #include "chrome/browser/profiles/profile.h" 32 #include "chrome/browser/profiles/profile.h"
31 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h" 33 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
32 #include "components/arc/arc_service_manager.h" 34 #include "components/arc/arc_service_manager.h"
33 #include "components/arc/arc_session.h" 35 #include "components/arc/arc_session.h"
34 #include "components/arc/arc_session_runner.h" 36 #include "components/arc/arc_session_runner.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 arc_service_manager_->AddService( 136 arc_service_manager_->AddService(
135 base::MakeUnique<ArcTtsService>(arc_bridge_service)); 137 base::MakeUnique<ArcTtsService>(arc_bridge_service));
136 arc_service_manager_->AddService( 138 arc_service_manager_->AddService(
137 base::MakeUnique<ArcWallpaperService>(arc_bridge_service)); 139 base::MakeUnique<ArcWallpaperService>(arc_bridge_service));
138 arc_service_manager_->AddService( 140 arc_service_manager_->AddService(
139 base::MakeUnique<GpuArcVideoServiceHost>(arc_bridge_service)); 141 base::MakeUnique<GpuArcVideoServiceHost>(arc_bridge_service));
140 } 142 }
141 143
142 void ArcServiceLauncher::OnPrimaryUserProfilePrepared(Profile* profile) { 144 void ArcServiceLauncher::OnPrimaryUserProfilePrepared(Profile* profile) {
143 DCHECK(arc_service_manager_); 145 DCHECK(arc_service_manager_);
146 DCHECK(arc_session_manager_);
147 // TODO(hidehiko): DCHECK(!arc_session_manager_->IsAllowed()) here.
148 // Do not expect it in real use case, but it is used for testing.
149 // Because the ArcService instances tied to the old profile is kept,
150 // and ones tied to the new profile are added, which is unexpected situation.
151 // For compatibility, call Shutdown() here in case |profile| is not
152 // allowed for ARC.
153 arc_session_manager_->Shutdown();
154
155 if (!IsArcAllowedForProfile(profile))
156 return;
157
158 // TODO(khmel): Move this to IsArcAllowedForProfile.
159 if (policy_util::IsArcDisabledForEnterprise() &&
160 policy_util::IsAccountManaged(profile)) {
161 VLOG(2) << "Enterprise users are not supported in ARC.";
162 return;
163 }
164
144 // List in lexicographical order 165 // List in lexicographical order
145 arc_service_manager_->AddService(base::MakeUnique<ArcBootPhaseMonitorBridge>( 166 arc_service_manager_->AddService(base::MakeUnique<ArcBootPhaseMonitorBridge>(
146 arc_service_manager_->arc_bridge_service(), 167 arc_service_manager_->arc_bridge_service(),
147 multi_user_util::GetAccountIdFromProfile(profile))); 168 multi_user_util::GetAccountIdFromProfile(profile)));
148 arc_service_manager_->AddService( 169 arc_service_manager_->AddService(
149 base::MakeUnique<ArcFileSystemOperationRunner>( 170 base::MakeUnique<ArcFileSystemOperationRunner>(
150 arc_service_manager_->arc_bridge_service(), profile)); 171 arc_service_manager_->arc_bridge_service(), profile));
151 arc_service_manager_->AddService(base::MakeUnique<ArcNotificationManager>( 172 arc_service_manager_->AddService(base::MakeUnique<ArcNotificationManager>(
152 arc_service_manager_->arc_bridge_service(), 173 arc_service_manager_->arc_bridge_service(),
153 multi_user_util::GetAccountIdFromProfile(profile))); 174 multi_user_util::GetAccountIdFromProfile(profile)));
154 175
155 // Kiosk apps should be run only for kiosk sessions. 176 // Kiosk apps should be run only for kiosk sessions.
156 if (user_manager::UserManager::Get()->IsLoggedInAsArcKioskApp()) { 177 if (user_manager::UserManager::Get()->IsLoggedInAsArcKioskApp()) {
157 // ArcKioskAppService is BrowserContextKeyedService so that it's destroyed 178 // ArcKioskAppService is BrowserContextKeyedService so that it's destroyed
158 // on destroying the Profile, that is after ArcServiceLauncher::Shutdown(). 179 // on destroying the Profile, that is after ArcServiceLauncher::Shutdown().
159 arc_service_manager_->AddService(base::MakeUnique<ArcKioskBridge>( 180 arc_service_manager_->AddService(base::MakeUnique<ArcKioskBridge>(
160 arc_service_manager_->arc_bridge_service(), 181 arc_service_manager_->arc_bridge_service(),
161 chromeos::ArcKioskAppService::Get(profile))); 182 chromeos::ArcKioskAppService::Get(profile)));
162 } 183 }
163 184
164 arc_session_manager_->OnPrimaryUserProfilePrepared(profile); 185 arc_session_manager_->SetProfile(profile);
186 arc_session_manager_->StartPreferenceHandler();
165 } 187 }
166 188
167 void ArcServiceLauncher::Shutdown() { 189 void ArcServiceLauncher::Shutdown() {
168 DCHECK(arc_service_manager_); 190 DCHECK(arc_service_manager_);
169 // Destroy in the reverse order of the initialization. 191 // Destroy in the reverse order of the initialization.
170 arc_service_manager_->Shutdown(); 192 arc_service_manager_->Shutdown();
171 arc_session_manager_.reset(); 193 arc_session_manager_.reset();
172 arc_service_manager_.reset(); 194 arc_service_manager_.reset();
173 } 195 }
174 196
175 } // namespace arc 197 } // namespace arc
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/arc_session_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698