Split ArcSessionManager::OnPrimaryUserProfilePrepared().

chrome/browser/chromeos/arc/arc_session_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 103 matching lines @@
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
   static void DisableUIForTesting();
   static void EnableCheckAndroidManagementForTesting();
 
   // Returns true if ARC is allowed to run for the current session.
   // TODO(hidehiko): The name is very close to IsArcAllowedForProfile(), but
   // has different meaning. Clean this up.
   bool IsAllowed() const;
 
-  void OnPrimaryUserProfilePrepared(Profile* profile);
   void Shutdown();
 
+  // Sets the |profile|, and sets up Profile related fields in this instance.
+  // IsArcAllowedForProfile() must return true for the given |profile|.
+  void SetProfile(Profile* profile);
+
   Profile* profile() { return profile_; }
   const Profile* profile() const { return profile_; }
 
   State state() const { return state_; }
 
+  // Starts observing Google Play Store enabled preference change.
+  // Also, based on its initial value, this may start ArcSession, or may start
+  // removing the data, as initial state.
+  // In addition, this triggers to show ArcAuthNotification, if necessary.
+  // Note that this must be called after SetProfile().
+  // TODO(hidehiko): Extract preference related code into a class to split the
+  // dependencty.
+  void StartPreferenceHandler();

[hidehiko, 2017/02/24 18:29:13]

Note: this is named after the new class planning to be extracted, which is
ArcPlayStoreEnabledPreferenceHandler, since we already have PreferenceHandler
for the class name which observes preference changes.

+
   // Adds or removes observers.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Adds or removes ArcSessionObservers.
   // TODO(hidehiko): The observer should be migrated into
   // ArcSessionManager::Observer.
   void AddSessionObserver(ArcSessionObserver* observer);
   void RemoveSessionObserver(ArcSessionObserver* observer);
 
@@ skipping 86 matching lines @@
   // Returns whether ARC is managed and all ARC related OptIn preferences are
   // managed too.
   bool AreArcAllOptInPreferencesManaged() const;
 
   void SetState(State state);
   void ShutdownSession();
   void OnOptInPreferenceChanged();
   void OnAndroidManagementPassed();
   void OnArcDataRemoved(bool success);
   void OnArcSignInTimeout();
-  void FetchAuthCode();

[hidehiko, 2017/02/24 18:29:13]

This is declared but not defined (unused). So slightly offtopic, but removed
here.

-  void PrepareContextForAuthCodeRequest();
 
   void StartArcAndroidManagementCheck();
   void MaybeReenableArc();
 
   // Called when the Android management check is done in opt-in flow or
   // re-auth flow.
   void OnAndroidManagementChecked(
       policy::AndroidManagementClient::Result result);
 
   // Called when the background Android management check is done. It is
@@ skipping 45 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ArcSessionManager);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os,
                          const ArcSessionManager::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_