Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 27089002: Use the system stdint.h on Windows in leveldatabase. (Closed)

Created:
7 years, 2 months ago by bungeman-chromium
Modified:
7 years, 2 months ago
Reviewers:
jsbell
CC:
chromium-reviews, dgrogan
Visibility:
Public.

Description

Use the system stdint.h on Windows in leveldatabase. Skia wishes to use the system stdint.h on Windows. This is now possible since VC2010 and later provide a stdint.h. VC2008 has been deprecated for building Chromium (and Skia) for a full year now. There are a number of stdint.h implementations in the codebase, some of which hide others, and most of which are not complete (Skia needs uintmax_t which most do not provide). The stdint.h in leveldatabase/src/port/win is incomplete and is also providing (apparently by accident) the stdint.h for Chromium's src/content. As such, it is also hiding the system stdint.h from Skia header files included in src/content. The stdint.h in leveldatabase/src/port/win is also the only file in that directory, so this change simply removes this directory from the list of includes. BUG=81490 R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228467

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M third_party/leveldatabase/leveldatabase.gyp View 1 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-chromium
7 years, 2 months ago (2013-10-12 03:24:59 UTC) #1
jsbell
On 2013/10/12 03:24:59, bungeman2 wrote: Viewing the patch gives an error - just me, or ...
7 years, 2 months ago (2013-10-12 18:53:05 UTC) #2
bungeman-chromium
On 2013/10/12 18:53:05, jsbell wrote: > On 2013/10/12 03:24:59, bungeman2 wrote: > > Viewing the ...
7 years, 2 months ago (2013-10-12 19:20:08 UTC) #3
jsbell
lgtm but I haven actually compared the stdint.h files. BTW you can use/resolve crbug.com/81490 - ...
7 years, 2 months ago (2013-10-13 03:05:00 UTC) #4
bungeman-chromium
7 years, 2 months ago (2013-10-14 16:50:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r228467.

Powered by Google App Engine
This is Rietveld 408576698