Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: pkg/front_end/lib/src/fasta/util/relativize.dart

Issue 2708893002: fasta: Cache relativizeUri(fileUri) on LibraryBuilder and ClassBuilder (or rather it's base class) (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/util/relativize.dart
diff --git a/pkg/front_end/lib/src/fasta/util/relativize.dart b/pkg/front_end/lib/src/fasta/util/relativize.dart
index 59e9f16b290ed986f35b02698718b58fc6f26862..e3fc03af6edf3579a0f77cd57780474fc9e7239b 100644
--- a/pkg/front_end/lib/src/fasta/util/relativize.dart
+++ b/pkg/front_end/lib/src/fasta/util/relativize.dart
@@ -10,5 +10,6 @@ String relativizeUri(Uri uri, {Uri base}) {
if (uri == null) return null;
base ??= Uri.base;
String result = "$uri";
- return result.startsWith("$base") ? result.substring("$base".length) : result;
+ final prefix = "$base";
+ return result.startsWith(prefix) ? result.substring(prefix.length) : result;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698