fasta: Cache relativizeUri(fileUri) on LibraryBuilder and ClassBuilder (or rather it's base class)

pkg/front_end/lib/src/fasta/builder/library_builder.dart

Index: pkg/front_end/lib/src/fasta/builder/library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/library_builder.dart b/pkg/front_end/lib/src/fasta/builder/library_builder.dart
index bf2eb9202d3211d5dce19bb77c969ca4b5559065..1e05ab13bb44600a4a30e42b95474f42e7fab823 100644
--- a/pkg/front_end/lib/src/fasta/builder/library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/library_builder.dart
@@ -17,6 +17,9 @@ import '../export.dart' show
 import '../loader.dart' show
     Loader;
 
+import '../util/relativize.dart' show
+    relativizeUri;
+
 import 'builder.dart' show
     Builder,
     ClassBuilder,
@@ -36,7 +39,8 @@ abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder {
 
   Uri get uri;
 
-  Uri get fileUri;
+  final Uri fileUri;
+  final String relativeFileUri;
 
   Map<String, Builder> get members;
 
@@ -46,6 +50,9 @@ abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder {
   Map<String, Builder> get exports;
 
   LibraryBuilder(Uri fileUri)
+      : this._internal(fileUri, relativizeUri(fileUri));
+
+  LibraryBuilder._internal(this.fileUri, this.relativeFileUri)

[ahe, 2017/02/21 14:15:22]

How about just having one constructor:

LibraryBuilder(Uri fileUri)
    : fileUri = fileUri,
      relativeFileUri = relativizeUri(fileUri)
      super(null, -1, fileUri);

[kustermann, 2017/02/22 14:40:28]

Done

       : super(null, -1, fileUri);
 
   Builder addBuilder(String name, Builder builder, int charOffset);