Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart

Issue 2708893002: fasta: Cache relativizeUri(fileUri) on LibraryBuilder and ClassBuilder (or rather it's base class) (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.kernel_procedure_builder; 5 library fasta.kernel_procedure_builder;
6 6
7 import 'package:kernel/ast.dart' show 7 import 'package:kernel/ast.dart' show
8 Arguments, 8 Arguments,
9 AsyncMarker, 9 AsyncMarker,
10 Constructor, 10 Constructor,
(...skipping 28 matching lines...) Expand all
39 39
40 import '../errors.dart' show 40 import '../errors.dart' show
41 internalError; 41 internalError;
42 42
43 import '../messages.dart' show 43 import '../messages.dart' show
44 warning; 44 warning;
45 45
46 import '../loader.dart' show 46 import '../loader.dart' show
47 Loader; 47 Loader;
48 48
49 import '../util/relativize.dart' show
50 relativizeUri;
51
52 import 'kernel_builder.dart' show 49 import 'kernel_builder.dart' show
53 Builder, 50 Builder,
54 ClassBuilder, 51 ClassBuilder,
55 ConstructorReferenceBuilder, 52 ConstructorReferenceBuilder,
56 FormalParameterBuilder, 53 FormalParameterBuilder,
57 KernelFormalParameterBuilder, 54 KernelFormalParameterBuilder,
58 KernelLibraryBuilder, 55 KernelLibraryBuilder,
59 KernelTypeBuilder, 56 KernelTypeBuilder,
60 KernelTypeVariableBuilder, 57 KernelTypeVariableBuilder,
61 MetadataBuilder, 58 MetadataBuilder,
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 final ConstructorReferenceBuilder redirectionTarget; 179 final ConstructorReferenceBuilder redirectionTarget;
183 180
184 KernelProcedureBuilder( 181 KernelProcedureBuilder(
185 List<MetadataBuilder> metadata, 182 List<MetadataBuilder> metadata,
186 int modifiers, KernelTypeBuilder returnType, String name, 183 int modifiers, KernelTypeBuilder returnType, String name,
187 List<TypeVariableBuilder> typeVariables, 184 List<TypeVariableBuilder> typeVariables,
188 List<FormalParameterBuilder> formals, this.actualAsyncModifier, 185 List<FormalParameterBuilder> formals, this.actualAsyncModifier,
189 ProcedureKind kind, KernelLibraryBuilder compilationUnit, int charOffset, 186 ProcedureKind kind, KernelLibraryBuilder compilationUnit, int charOffset,
190 [String nativeMethodName, this.redirectionTarget]) 187 [String nativeMethodName, this.redirectionTarget])
191 : procedure = new Procedure(null, kind, null, 188 : procedure = new Procedure(null, kind, null,
192 fileUri: relativizeUri(compilationUnit?.fileUri)), 189 fileUri: compilationUnit?.relativeFileUri),
193 super(metadata, modifiers, returnType, name, typeVariables, formals, 190 super(metadata, modifiers, returnType, name, typeVariables, formals,
194 compilationUnit, charOffset, nativeMethodName); 191 compilationUnit, charOffset, nativeMethodName);
195 192
196 ProcedureKind get kind => procedure.kind; 193 ProcedureKind get kind => procedure.kind;
197 194
198 AsyncMarker get asyncModifier => actualAsyncModifier; 195 AsyncMarker get asyncModifier => actualAsyncModifier;
199 196
200 Statement get body { 197 Statement get body {
201 if (actualBody == null && redirectionTarget == null && !isAbstract && 198 if (actualBody == null && redirectionTarget == null && !isAbstract &&
202 !isExternal) { 199 !isExternal) {
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 } 328 }
332 } 329 }
333 initializers.add(initializer..parent = constructor); 330 initializers.add(initializer..parent = constructor);
334 initializers.add(superInitializer); 331 initializers.add(superInitializer);
335 return; 332 return;
336 } 333 }
337 initializers.add(initializer); 334 initializers.add(initializer);
338 initializer.parent = constructor; 335 initializer.parent = constructor;
339 } 336 }
340 } 337 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart ('k') | pkg/front_end/lib/src/fasta/util/relativize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698